Navigating in Moose Finder is slow

[seandenigris]

Originally reported on Google Code with ID 994

It's just that. Navigating in the Moose Finder is slow for some reason.

Reported by tudor@tudorgirba.com on 2013-11-07 20:28:28

[seandenigris]

The issue comes from 

MooseGroupStorage>>"protocol: private"
becomeKind: elementStorageClass 

    [elementStorageClass includesBehavior: MooseGroupStorage] assert.
    self do: [ :each | 
        each hasUniqueMooseNameInModel ifTrue: [ each privateClearMooseName ] ].
    self class = elementStorageClass 
        ifFalse: [self become: (elementStorageClass withAll: self)]

Reported by tudor@tudorgirba.com on 2013-11-07 20:44:49

[seandenigris]

Name: Moose-Core-TudorGirba.405
Author: TudorGirba
Time: 7 November 2013, 9:46:35.349054 pm
UUID: 9386cadf-127a-4768-83e0-38d84f711670
Ancestors: Moose-Core-TudorGirba.404

put the guard condition first before doing anything in becomeKind:

"protocol: private"
becomeKind: elementStorageClass 

    self class = elementStorageClass ifTrue: [ ^ self ].
    [elementStorageClass includesBehavior: MooseGroupStorage] assert.
    self do: [ :each | 
        each hasUniqueMooseNameInModel ifTrue: [ each privateClearMooseName ] ].
    self become: (elementStorageClass withAll: self)

Reported by tudor@tudorgirba.com on 2013-11-07 20:47:08

• Status changed: Fixed
• Labels added: Component-MooseCore