Skip to content

Loading…

Documentation: Request.JSON's behaviour of onFailure #2110

Closed
afoeder opened this Issue · 1 comment

3 participants

@afoeder

the base Request's onFailure behaviour that is mentioned in the documentation says

Fired when the request failed (error status code).

the inheriting Request.JSON's onFailure behaviour does in fact, additionally, also occur when the JSON string is not parseable. This fact is not covered by the docs, so it should be emphasized that onFailure is also overridden / extended by Request.JSON.

@timwienk
MooTools member

Indeed. The docs should mention the conditions for failure are different for Request.JSON.

@timwienk timwienk was assigned
@ibolmo ibolmo added a commit to ibolmo/mootools-core that referenced this issue
@ibolmo ibolmo Fixes #2110.
Missing docs onFailure event called also for invalid JSON strings. Also added missing See Also section in the Request.JSON.md.
9c5d965
@cpojer cpojer closed this in 27c958b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.