Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Documentation: Request.JSON's behaviour of onFailure #2110

Closed
afoeder opened this Issue · 1 comment

3 participants

Adrian Föder Tim Wienk Christoph Pojer
Adrian Föder

the base Request's onFailure behaviour that is mentioned in the documentation says

Fired when the request failed (error status code).

the inheriting Request.JSON's onFailure behaviour does in fact, additionally, also occur when the JSON string is not parseable. This fact is not covered by the docs, so it should be emphasized that onFailure is also overridden / extended by Request.JSON.

Tim Wienk
Owner

Indeed. The docs should mention the conditions for failure are different for Request.JSON.

Tim Wienk timwienk was assigned
Olmo Maldonado ibolmo referenced this issue from a commit in ibolmo/mootools-core
Olmo Maldonado ibolmo Fixes #2110.
Missing docs onFailure event called also for invalid JSON strings. Also added missing See Also section in the Request.JSON.md.
9c5d965
Christoph Pojer cpojer closed this in 27c958b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.