Element object can't create a button with the type of button. #2113

Closed
tvanreenen opened this Issue Oct 27, 2011 · 5 comments

Projects

None yet

5 participants

@tvanreenen

The fiddle should be able to explain it all. I doubt this is a bug with MooTools. But, it does seem like a behavior that MooTools should be compensating for.

http://jsfiddle.net/tvanreenen/nHpVc/

@tvanreenen

I should have mentioned that I'm using Safari 5.1.1. I didn't make an effort to test any other browsers. I'll post back if and when I get to that.

@arian
Member
arian commented Oct 27, 2011

Hmm, so you're saying .set should use .setAttribute for type on button elements...

@tvanreenen

Yeah, immediately thats about the only solution that comes to mind.

@jabis
jabis commented Nov 4, 2011

Just fyi: setting the actual Attributes using setProperty on any form/input elements has been long known to cause issues on different browsers ( IE for certain )

@ibolmo
Member
ibolmo commented Nov 29, 2011

Yeah this is a webkit bug: https://bugs.webkit.org/show_bug.cgi?id=14439

I can write a fix, though so that Element.set fixes this in the mean time. Stay tuned.

@ibolmo ibolmo added a commit to ibolmo/mootools-core that referenced this issue Nov 29, 2011
@ibolmo ibolmo Fixes #2113.
Webkit bug: https://bugs.webkit.org/show_bug.cgi?id=14439 prevents
button.type = 'button' from working as expected. Current solution is to
use setAttribute. This fix adds propertySetter.type with setAttribute
but only for webkit.
0ecfdbe
@ibolmo ibolmo referenced this issue Nov 29, 2011
Merged

Fixes #2113. #2143

@ibolmo ibolmo added a commit that closed this issue Nov 29, 2011
@ibolmo ibolmo Fixes #2113.
Webkit bug: https://bugs.webkit.org/show_bug.cgi?id=14439 prevents
button.type = 'button' from working as expected. Current solution is to
use setAttribute. This fix adds propertySetter.type with setAttribute
but only for webkit.
0ecfdbe
@ibolmo ibolmo closed this in 0ecfdbe Nov 29, 2011
@cpojer cpojer closed this in 25afa16 Nov 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment