Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Document conflicts between Array and Elements methods #2117

Closed
barryvan opened this Issue · 1 comment

2 participants

@barryvan

At present, the Elements documentation states that all Element methods are available on the Elements collection. However, there are some methods implemented on Array which take precedence over methods with the same name on Element. As far as I can tell, these are:

  • erase
  • clone
  • contains
  • getLast
  • empty
  • filter (note that for "filter", Elements.filter takes precedence over Array.filter)
@barryvan

There's also the potential for confusion between Elements.from and Array.from.

@ibolmo ibolmo referenced this issue from a commit in ibolmo/mootools-core
@ibolmo ibolmo Fixes #2117 and added missing deprecations.
Added docs for:

 Elements.append
 Elements.concat
 Elements.empty
 Elements.push
 Elements.unshift

Deprecation docs warnings for:

 Elements.extend
 Element.inject(Before, After, Bottom, Top, Inside)
 Element.grab(Before, After, Bottom, Top, Inside)

Improved docs for:

 Elements.filter
c98b508
@ibolmo ibolmo closed this in e365bcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.