Document conflicts between Array and Elements methods #2117

Closed
barryvan opened this Issue Nov 2, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@barryvan
Contributor

barryvan commented Nov 2, 2011

At present, the Elements documentation states that all Element methods are available on the Elements collection. However, there are some methods implemented on Array which take precedence over methods with the same name on Element. As far as I can tell, these are:

  • erase
  • clone
  • contains
  • getLast
  • empty
  • filter (note that for "filter", Elements.filter takes precedence over Array.filter)
@barryvan

This comment has been minimized.

Show comment
Hide comment
@barryvan

barryvan Nov 2, 2011

Contributor

There's also the potential for confusion between Elements.from and Array.from.

Contributor

barryvan commented Nov 2, 2011

There's also the potential for confusion between Elements.from and Array.from.

ibolmo added a commit to ibolmo/mootools-core that referenced this issue Dec 3, 2011

Fixes #2117 and added missing deprecations.
Added docs for:

 Elements.append
 Elements.concat
 Elements.empty
 Elements.push
 Elements.unshift

Deprecation docs warnings for:

 Elements.extend
 Element.inject(Before, After, Bottom, Top, Inside)
 Element.grab(Before, After, Bottom, Top, Inside)

Improved docs for:

 Elements.filter

@ibolmo ibolmo closed this in e365bcc Dec 3, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment