change in the way Element.prototype.fade overloads arguments to Fx.Tween #2125

Closed
DimitarChristoff opened this Issue Nov 16, 2011 · 2 comments

Comments

Projects
None yet
2 participants
Member

DimitarChristoff commented Nov 16, 2011

This is one of these undocumented features that I have always taken for granted:

element.fade(0, 1); behaviour has changed in 1.4

previously, the switch statement would pass on all arguments to the Fx.Tween instance so the above would work:
https://github.com/mootools/mootools-core/blob/1.3x/Source/Fx/Fx.Tween.js#L84

now, the default on the switch reverts to working with a single argument only (how), which means you cannot set the start value of the tween, only the end one.
https://github.com/mootools/mootools-core/blob/master/Source/Fx/Fx.Tween.js#L85

The old behaviour was rather nice, it provided an Element shortcut API into Fx.Tween, can it be reverted back, please as it's a breaking change that is not warranted by any real concern.

arian added a commit to arian/mootools-core that referenced this issue Nov 16, 2011

Owner

arian commented Nov 16, 2011

See pull #2126

Member

DimitarChristoff commented Nov 16, 2011

thanks so much! awesome.

arian added a commit to ibolmo/mootools-core that referenced this issue Dec 20, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment