Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

change in the way Element.prototype.fade overloads arguments to Fx.Tween #2125

Closed
DimitarChristoff opened this Issue · 2 comments

2 participants

Dimitar Christoff Arian Stolwijk
Dimitar Christoff
Collaborator

This is one of these undocumented features that I have always taken for granted:

element.fade(0, 1); behaviour has changed in 1.4

previously, the switch statement would pass on all arguments to the Fx.Tween instance so the above would work:
https://github.com/mootools/mootools-core/blob/1.3x/Source/Fx/Fx.Tween.js#L84

now, the default on the switch reverts to working with a single argument only (how), which means you cannot set the start value of the tween, only the end one.
https://github.com/mootools/mootools-core/blob/master/Source/Fx/Fx.Tween.js#L85

The old behaviour was rather nice, it provided an Element shortcut API into Fx.Tween, can it be reverted back, please as it's a breaking change that is not warranted by any real concern.

Arian Stolwijk arian referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Arian Stolwijk arian referenced this issue from a commit in arian/mootools-core
Arian Stolwijk arian Fixes #2125 - re-add undocumented from argument to Element.fade a7816d9
Arian Stolwijk
Owner

See pull #2126

Dimitar Christoff
Collaborator

thanks so much! awesome.

Arian Stolwijk arian referenced this issue from a commit in ibolmo/mootools-core
Arian Stolwijk arian Fixes #2125 - re-add undocumented from argument to Element.fade 45cd384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.