Fix #2100. Element.erase caused unexpected values for the attributes #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment.get the unexpected results. Added a feature detect if the browser sets 'null' instead of null in the attribute. Added a `Element.Property` for class. TESTED: Opera 11, Safari 5, Firefox 3-5, 8, 10, Chrome latest, IE6-9.
|
Fixes #2100. |
| @@ -863,6 +868,20 @@ Element.Properties.style = { | |||
|
|
|||
| }; | |||
|
|
|||
| if ('className' in document.documentElement){ | |||
There was a problem hiding this comment.
Yeah I thought it strange too, but as you noticed in L557, we still check against it.
Removed unnecessary Element.Properties.class and opted to use propertySetter and getter. Adding for condition to set the value to '' instead of null (IE would set to 'null'). Refactored setProperty. Now much simpler. Checks for propertySetter and assumes it'll take responsibility in cleaning up the value (and to set it). Still removeAttribute if no setter, and value is null. Passes all specs, and therefore, it's backwards compatible. PASSED: IE6-9, FFx 3-5, 8, 10, Chrome latest, Safari 5, Opera 11.
|
Naice. Looks like this fixes #2108 as well |
cpojer
added a commit
that referenced
this pull request
Nov 29, 2011
Fix #2100. Element.erase caused unexpected values for the attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a feature detect if the browser sets 'null' instead of null in the
attribute.
Added a
Element.Propertyfor class.TESTED: Opera 11, Safari 5, Firefox 3-5, 8, 10, Chrome latest, IE6-9.