Skip to content
This repository

Memory leak with request class #2243

Closed
ibolmo opened this Issue · 3 comments

4 participants

Olmo Maldonado Darren Waddell André Cruz gd0t
Olmo Maldonado
Owner

(from Lighthouse)

There is still a memory leak in 1.4.0 pretty much the same as ticket: https://mootools.lighthouseapp.com/projects/2706/tickets/1123-memor...

Which is closed already

Example, load a big file in form.htm! and click a few times the memory will only go up as in the screenshot, this will happen in all browsers not only IE is just test on IE with the CollectGarbage method.

The leak is in Request too btw so every ajax request will suffer!

<!DOCTYPE html>


<head>
    <title></title>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    <script type="text/javascript" src="mootools-core-1.4.0-full-compat.js"></script>
    <script type="text/javascript">
        window.addEvent('domready', function() {                
            var ajaxContent = $('AjaxContent');
            $('loadAjax').addEvent('click', function(e){
                var options = {
                    url: 'form.html',
                    evalScripts: true,
                    update: ajaxContent,
                    onSuccess: function(){
                        CollectGarbage();
                    }
                }
                var xhr = new Request.HTML(options);
                xhr.send();
                return false;
            });                
        });
    </script>
</head>
<body>
    <a href="" id="loadAjax">AJAX REQUEST</a>
    <div id="AjaxContent">

    </div>
</body>
André Cruz

Is this a problem with Request.HTML or also with Request?

Olmo Maldonado
Owner

I believe the ticket said that Request was fine, but Request.HTML was leaking. I haven't verified the ticket, though.

gd0t
gd0t commented

Is there a temporary workaround until 1.4.5 gets rolled out?

Darren Waddell fakedarren closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.