Behavior of Request.JSON failure is still wrong #2489

Closed
rbpasker opened this Issue Apr 3, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@rbpasker

rbpasker commented Apr 3, 2013

regarding #2110, i've attached a debugger image that shows that an invalid JSON document generating an 'error' event, rather than calling onFailure().

either the code has to be fixed, or the docs

JSON parse error

@arian

This comment has been minimized.

Show comment Hide comment
@arian

arian Apr 3, 2013

Owner

It is in the docs, isn't it: 27c958b

(Although it might not be live yet.)

Owner

arian commented Apr 3, 2013

It is in the docs, isn't it: 27c958b

(Although it might not be live yet.)

@arian arian closed this Apr 3, 2013

@rbpasker

This comment has been minimized.

Show comment Hide comment
@rbpasker

rbpasker Apr 3, 2013

no, its STILL WRONG

rbpasker commented Apr 3, 2013

no, its STILL WRONG

@rbpasker

This comment has been minimized.

Show comment Hide comment
@rbpasker

rbpasker Apr 3, 2013

it not calling onFailure, its calling onError

+#### failure
+
+Fired when the request failed (error status code), or when JSON string could not be parsed.
+

rbpasker commented Apr 3, 2013

it not calling onFailure, its calling onError

+#### failure
+
+Fired when the request failed (error status code), or when JSON string could not be parsed.
+

@arian arian reopened this Apr 3, 2013

@arian

This comment has been minimized.

Show comment Hide comment
@arian

arian Apr 3, 2013

Owner

Ah, good catch.

Owner

arian commented Apr 3, 2013

Ah, good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment