Fixes #2125 - re-add undocumented from argument to Element.fade #2126

wants to merge 1 commit into


None yet

3 participants

arian commented Nov 16, 2011

Only concern is that it doesn't get prettier, don't know if there are better solutions?


excellent. thank you so much :)

ibolmo commented Nov 23, 2011

Ok I think I understand how this got all jumbled up.

Here's when we had the default: fade.start(o, arguments); 1;

Here's when we had the visibility problems with fade 2.

Finally we're trying to get this going because default case is no longer present.

I think this function would be simplified if we dealt with the visibility problems separately.

Here's an untested and probably not done work, but I think it's clear of the direction I'd like for us to go:

ibolmo commented Dec 19, 2011

@arian the only thing missing is just a spec that covers this special case. perhaps in a compat test.

ibolmo commented Dec 20, 2011

See: 45cd384

@ibolmo ibolmo closed this Dec 20, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment