Fixes #2118. #2144

Merged
merged 1 commit into from Nov 30, 2011

Conversation

Projects
None yet
4 participants
Owner

ibolmo commented Nov 29, 2011

Noticed that there's no $uid dependency in Browser.js. Moved $uid and
$uid calls for window and document to Element.js.

Owner

ibolmo commented Nov 29, 2011

Fixes #2118.

Here's the specs: mootools/mootools-core-specs#26

PASSED: IE6-9, FFx 3-5, 8, 10, Opera 11, Chrome latest, Safari 5

Owner

ibolmo commented Nov 29, 2011

Yeah I agree. @cpojer, do you concur?

Owner

cpojer commented Nov 29, 2011

Yeah we can do this.

Owner

arian commented Nov 29, 2011

+1 for using Slick.uidOf

Member

fabiomcosta commented Nov 29, 2011

wait a minute... I'm afraid it wont be possible to use Slick.uidOf on window nor document at IE. Please check if everything is working fine... $uid used to work on XML nodes, as well as at the document.

@@ -275,7 +280,7 @@ Document.implement({
};
return function(el, nocash, doc){
- if (el && el.$family && el.uid) return el;
+ if (el && el.$family && el.uniqueNumber) return el;
@cpojer

cpojer Nov 29, 2011

Owner

Mind putting a comment here on why uniqueNumber is accessed?

Owner

ibolmo commented Nov 29, 2011

@fabiomcosta I ran the specs against IE6-9, Safari 5, Chrome latest, Opera 11, FFx 3-5, 8, 10. All PASS.

Only scenario is that we didn't have a spec that would fail. Do you have a XML node test we should use?

Member

fabiomcosta commented Nov 29, 2011

nevermind then... It's not documented and not meant to be public... keep it :)

Fixes #2118.
Noticed that there's no $uid dependency in Browser.js, moved to
Element.js. Removed $uid in favor of Slick.uidOf.

PASSED: IE6-9; FFx 3-5, 8, 10; Opera 11; Safari 5; Chrome latest

cpojer added a commit that referenced this pull request Nov 30, 2011

@cpojer cpojer merged commit 65b1df5 into mootools:master Nov 30, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment