Fixes #2164. #2197

Merged
merged 1 commit into from Jan 9, 2012

Conversation

Projects
None yet
3 participants
@ibolmo
Member

ibolmo commented Jan 9, 2012

Changed value property setter was too strict with defaulting to an empty
string. Now Element.set('value') for falsey values depends on toString
of that object for setting the right value.

PASSED: IE6-9; FFx 3-5, 8; 10; Safari 5; Opera 11; Chrome latest

Fixes #2164.
Changed value property setter was too strict with defaulting to an empty
string. Now Element.set('value') for falsey values depends on toString
of that object for setting the right value.

PASSED: IE6-9; FFx 3-5, 8; 10; Safari 5; Opera 11; Chrome latest

cpojer added a commit that referenced this pull request Jan 9, 2012

@cpojer cpojer merged commit d05c9fb into mootools:master Jan 9, 2012

@angelsk

This comment has been minimized.

Show comment
Hide comment
@angelsk

angelsk May 14, 2012

This still happens in IE7 - you cannot set the dropdown to value 0 - this is using 1.4.5 (and the dropdown has a blank value as well - it's a time widget).

This still happens in IE7 - you cannot set the dropdown to value 0 - this is using 1.4.5 (and the dropdown has a blank value as well - it's a time widget).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment