Update files to not throw an error in "use strict" mode. #2379 #2380

Open
wants to merge 2 commits into
from

Projects

None yet

6 participants

@GCheung55

@arian and @kentaromiura, check it out?

@arian
MooTools member

It was like this before, but it was also reverted: GCheung55@8521f48

I think that Cajon (https://github.com/requirejs/cajon) shouldn't just throw out "use strict"s outside some function scope, which it does if I understand you correctly.

@kentaromiura
MooTools member

@arian please add details
:trollface:

@DimitarChristoff
MooTools member

i like it.

@GCheung55

@arian Right. I think it shouldn't be aggressively enforcing 'use strict' either. But there will be cases like this, where a concat'd file has 'use strict' somewhere at the top.. and issues will occur.

The more interesting thing is that 'use strict' is inside cajon's function block scope. It shouldn't affect eval's scope.. should it?

@cpojer Could you comment why adding .call(this) was reverted? What would be a better fix?

@cpojer
MooTools member

iirc the problem was that the file-scope this isn't always the global context.

@SergioCrisostomo SergioCrisostomo modified the milestone: 1.5.1, 1.6.0 May 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment