Bugfix 2296 #2422

Closed
wants to merge 10 commits into from

1 participant

@kentaromiura
MooTools member

fix for bug no #2296

kentaromiura and others added some commits Apr 10, 2012
@kentaromiura kentaromiura fix for mootools#2230
had to check if every result is element, otherwise it will break Element.toQueryString 

I checked, using Array.forEachMethod, if other methods return typeOf 'array'
and found two other methods other than map, splice and slice.
With this patch I address the clone() but not the flatten() method, because i think the latter should correctly return an array.
6567fa2
@kentaromiura kentaromiura changed the way of checking for the method to apply, using Arian style
added flatten to the list of the method to fix
removed useless always-true checking 
using short-circuit to avoid looking for all the elements if not on map
changed coding standard to adhere to mootools standards (i hope so :P)
96f7bfd
@kentaromiura kentaromiura using a variable to keep track of which method need every element che…
…cked (right now is only map)
f753135
@kentaromiura kentaromiura Saving few bytes b873bee
Cristian Carlesso Merge branch 'master' of https://github.com/kentaromiura/mootools-core e2757ac
Cristian Carlesso add some tests for issue 2230
add some tests for issue 2230
961d459
Cristian Carlesso Merge branch 'master' of https://github.com/kentaromiura/mootools-core 2f40d16
Cristian Carlesso Merge branch 'master' of https://github.com/kentaromiura/mootools-core a6ed475
Cristian Carlesso saving a ref in order to remove the unload method
saving a ref in order to remove the unload method
20533d0
Cristian Carlesso adding test to check if the removal of unload works now
adding test to check if the removal of unload works now
22fb309
@kentaromiura
MooTools member

sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment