saving a ref in order to remove the unload method #2423

Merged
merged 2 commits into from Sep 2, 2012

Conversation

Projects
None yet
2 participants
Member

kentaromiura commented Sep 2, 2012

saving a ref in order to remove the unload method
add some test

Cristian Carlesso saving a ref in order to remove the unload method
saving a ref in order to remove the unload method
add some test
a71e9f9

@arian arian commented on an outdated diff Sep 2, 2012

Source/Element/Element.js
@@ -913,6 +913,11 @@ Element.implement({
},
removeListener: function(type, fn){
+ if (fn.$ref){
@arian

arian Sep 2, 2012

Owner

if (type == 'unload' && fn.$ref){

Cristian Carlesso adding a further check
adding a further check
b0de803

@arian arian added a commit that referenced this pull request Sep 2, 2012

@arian arian Merge pull request #2423 from kentaromiura/fixbug-2296
fixes #2296 - saving a ref in order to remove the unload method
3b0388b

@arian arian merged commit 3b0388b into mootools:master Sep 2, 2012

@arian arian added a commit to arian/mootools-core that referenced this pull request Sep 5, 2012

@arian arian Better fix for #2296 and #2423 - doesn't wrap onunload functions in a…
…ddListener anymore.
d54312c

@kentaromiura kentaromiura added a commit to kentaromiura/mootools-core that referenced this pull request Oct 25, 2012

@arian @kentaromiura arian + kentaromiura Better fix for #2296 and #2423 - doesn't wrap onunload functions in a…
…ddListener anymore.
f3ce01b

@arian arian added a commit to ibolmo/mootools-core that referenced this pull request Feb 16, 2014

@arian @ibolmo arian + ibolmo Better fix for #2296 and #2423 - doesn't wrap onunload functions in a…
…ddListener anymore.
4781d33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment