Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes for 1.2.6 #2462

Merged
merged 3 commits into from Jan 15, 2013

Conversation

Projects
None yet
2 participants
Owner

arian commented Jan 15, 2013

No description provided.

arian added some commits Jan 15, 2013

Fixes #2402 for 1.2. Overwrite String contains with the MooTools vers…
…ion.

Firefox 18 implements .contains, and ES6 might do that as well. That breaks
some stuff, so we have to make sure it's overwritten with the 'correct'
MooTools version.
Owner

arian commented Jan 15, 2013

Tested the specs in IE6, IE8, IE9, Firefox 18, Chrome 24 and Opera 12.

Owner

arian commented Jan 15, 2013

I added the try-catch because it's the same in Function.js. I guess when browsers define it with the {writable: false} definition or something…, @cpojer ?

Owner

cpojer commented Jan 15, 2013

sure, whynot, merge it.

arian added a commit that referenced this pull request Jan 15, 2013

@arian arian merged commit a3be7a0 into mootools:1.2x Jan 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment