Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix #2428 IE8: Fx.Morph percentage unit issue #2477

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

gmaes commented Mar 15, 2013

This pull request fixes the unit issue in the Fx.CSS class.
Indeed, we can not morph a property using a specific unit (let say %) and a color property at the same time.
This example fails:

el.set("morph", {
    "duration": 1000,
    "unit": "%"
});
el.get("morph").start({
    "height": "50",
    "background-color": "#00FF00"
});

The animation on the background-color does not work.

Contributor

gonchuki commented Mar 15, 2013

I like it.
Could you add some tests for this fix?

@ibolmo ibolmo added this to the 1.5.1 milestone Mar 3, 2014

@ibolmo ibolmo added the incomplete label Mar 3, 2014

Member

SergioCrisostomo commented Jun 1, 2014

Example of the broken behaviour: http://jsfiddle.net/Ss8k2/2/

This PR is a good step to fix this but fixes only partially the problem: http://jsfiddle.net/Ss8k2/

@SergioCrisostomo SergioCrisostomo modified the milestone: 1.5.2, 1.5.1 Jul 3, 2014

Owner

ibolmo commented Nov 11, 2014

I'm going to defer this for 1.6. This may resolve itself with #2503.

@ibolmo ibolmo modified the milestone: 1.6.0, 1.5.2 Nov 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment