It doesn't need to lookup keynames with keypress and shift
With keypress shift+1 generates keyCode 33, which maps to pageup when this is added with defineKeys.
We should use Syn.js to simulate the typing, and make sure we're getting out the right values. This would minimize future changes like this.
This is a interesting issue since @arian 's jsFiddle behaves different if More is included or not, respective pageup / !. I just tested More with all the Core specs inside it and got no extra failing Spec. That is good. But would like also to be able to Spec this one and see that different behavior reflected there.
I didn't manage to use Syn with SHIFT, but asked them for help on that.
Just missing the spec based on http://jsfiddle.net/2zsNV/5/
@ibolmo @arian could this be a good spec for this: SergioCrisostomo@d293e98 ?
Fix event.key for keypress. It doesn't need to lookup keynames with k…
…eypress and shift
add spec for 2493
I added your commit and rebased this pull request.