Fix event.key for keypress. #2493

Merged
merged 2 commits into from Feb 8, 2015

3 participants

@arian
MooTools member

It doesn't need to lookup keynames with keypress and shift

mootools/mootools-more#1194

jsfiddle: http://jsfiddle.net/6xf4M/

With keypress shift+1 generates keyCode 33, which maps to pageup when this is added with defineKeys.

@ibolmo ibolmo added this to the 1.5.1 milestone Mar 3, 2014
@ibolmo ibolmo added the bug label Mar 3, 2014
@ibolmo
MooTools member

We should use Syn.js to simulate the typing, and make sure we're getting out the right values. This would minimize future changes like this.

@SergioCrisostomo
MooTools member

This is a interesting issue since @arian 's jsFiddle behaves different if More is included or not, respective pageup / !. I just tested More with all the Core specs inside it and got no extra failing Spec. That is good. But would like also to be able to Spec this one and see that different behavior reflected there.

I didn't manage to use Syn with SHIFT, but asked them for help on that.

@ibolmo
MooTools member

Just missing the spec based on http://jsfiddle.net/2zsNV/5/

@SergioCrisostomo SergioCrisostomo modified the milestone: 1.5.2, 1.5.1 Jul 6, 2014
@SergioCrisostomo
MooTools member

@ibolmo @arian could this be a good spec for this: SergioCrisostomo@d293e98 ?

@arian
MooTools member

I added your commit and rebased this pull request.

@SergioCrisostomo
MooTools member

👍

@SergioCrisostomo SergioCrisostomo merged commit 7dd4a07 into mootools:master Feb 8, 2015

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed
@SergioCrisostomo SergioCrisostomo referenced this pull request in mootools/mootools-more Feb 23, 2015
Closed

key events for shift+1 results in wrong key #1194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment