Merged
Conversation
…t not identical to the original element.
karma-sauce-connect uses sauce-connect-launcher to download the right Sauce Connect.
These tasks use the karma:dev config that's already there.
…rma-sinon. IE compatibility was coincindentally inherited from Utilities/sinon.js, karma-sinon-ie loads the right files from the sinon package to do this in a reliable way instead. The "sinon"-package was already installed through karma-sinon's peerDependancy, now added to package.json as well.
Also updated Specs files to work with newer version of syn.
Apparently triggering a click on an <a href="javascript:somethin()" />
in IE9 and IE10 causes a page reload of which Karma doesn't approve.
Since we don't use this functionality in our tests anyway, preventing
that trigger from happening has no effects for us.
Diff of the change to the original source (before building):
--- a/src/mouse.support.js
+++ b/src/mouse.support.js
@@ -22,7 +22,7 @@ if (!document.body) {
select = form.getElementsByTagName('select')[0];
//trigger click for linkHrefJS support, childNodes[6] === anchor
- syn.trigger(form.childNodes[6], 'click', {});
+ //syn.trigger(form.childNodes[6], 'click', {});
checkbox.checked = false;
checkbox.onchange = function () {
Even though Jasmine 2.3 has been in the devDependencies, the version of karma-jasmine we used came with its own Jasmine 1.3.
Also includes sinon in server spec runner, since the newly added spec files use it.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in #2734.
$$spec actually turned out to be broken after adding actual elements to select.Tests/Utilitiesand includedsynandsinonpackages instead, addedTests/Plugins/synto usesynin karma. Last commit re-adds a local version ofsyn(hopefully temporarily).