Skip to content

Commit

Permalink
Fixes #498 - Form.Validator OnElementPass event has parameter 'undefi…
Browse files Browse the repository at this point in the history
…ned'

https://mootools.lighthouseapp.com/projects/24057/tickets/498

+ Array.from(field) returns [] in firefox ... so we wrap it in array
+ adds spec
  • Loading branch information
fat authored and Arian committed Feb 23, 2011
1 parent 075e026 commit 358378c
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Source/Forms/Form.Validator.js
Expand Up @@ -212,7 +212,7 @@ Form.Validator = new Class({
if (validators && !this.hasValidator(field,'warnOnly')){
if (passed){
field.addClass('validation-passed').removeClass('validation-failed');
this.fireEvent('elementPass', field);
this.fireEvent('elementPass', [field]);
} else {
field.addClass('validation-failed').removeClass('validation-passed');
this.fireEvent('elementFail', [field, validatorsFailed]);
Expand Down
31 changes: 31 additions & 0 deletions Specs/1.3/Forms/Form.Validator.js
@@ -1,5 +1,36 @@
describe('Form.Validator', function(){

describe('onElementPass', function(){

var form, select;
beforeEach(function(){
form = new Element('form', {
action: '#'
}).adopt(
select = new Element('select', {
'class': 'minLength:2'
}).adopt(
[1, 2, 3].map(function(item){
return new Element('option', {html: item, value: item});
})
)
);
});

afterEach(function(){
form = select = null;
});

it('should pass the field as an argument', function(){
var spy = jasmine.createSpy();
new Form.Validator(form, {
onElementPass: spy
}).validate();
expect(spy).toHaveBeenCalledWith(select);
});

});

describe('Validators', function(){

getValidator = Form.Validator.getValidator.bind(Form.Validator);
Expand Down

0 comments on commit 358378c

Please sign in to comment.