Sortables fix pull request #1116

Closed
jakobholmelund opened this Issue Mar 29, 2012 · 3 comments

Projects

None yet

2 participants

@jakobholmelund

Hi guys, i have a minor fix for sortables.. The complete event fires before the clone is destroyed from the chained function destroy, i have made a fork and fixed, commit can be seen here

madfarmer/mootools-more@ff365d4

i write here because i cant make a pull request.

@arian
Member
arian commented Mar 29, 2012

I think this looks ok. Can you create a small jsfiddle when with the failing behavior?

@jakobholmelund

sure.. http://jsfiddle.net/m3Ztn/7/ and then drag one of the colors, as you see serialize also includes the clone because event fires before it is destroyed..

@jakobholmelund

argh.. here without alert http://jsfiddle.net/m3Ztn/11/

@SergioCrisostomo SergioCrisostomo added a commit to SergioCrisostomo/mootools-more that referenced this issue Apr 26, 2014
@SergioCrisostomo SergioCrisostomo fixes #1116
- Fixed small bug in Jakobs nice fix
- added first automated interactive spec! (http://jsfiddle.net/Px7sq/)
3e978da
@SergioCrisostomo SergioCrisostomo added a commit that closed this issue Apr 29, 2014
@SergioCrisostomo SergioCrisostomo fixes #1116
- Fixed small bug in Jakobs nice fix
- added first automated interactive spec! (http://jsfiddle.net/Px7sq/)
29df62c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment