Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmet peer dependency: sinon@* #1339

Closed
olvlvl opened this issue Feb 7, 2016 · 4 comments

Comments

@olvlvl
Copy link
Contributor

commented Feb 7, 2016

Hi,

I tryed to run the tests for mootools-more but there was a dependency issue.

│   └── lodash@2.4.2
├── mootools-core@1.6.1-dev
├── requirejs@2.1.22
└── UNMET PEER DEPENDENCY sinon@*

npm WARN karma-sinon@1.0.4 requires a peer of sinon@* but none was installed.

I followed the steps defined in the README:

$ git clone https://github.com/mootools/mootools-more  # clone the MooTools repo
$ cd mootools-more                                     # get into the directory
$ npm install                                          # install de testing tools
$ npm install grunt-cli -g                             # install the Grunt command line interface
$ grunt default                                        # run the specs!

I fixed it by installing the package myself:

$ npm install sinon

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30622097-unmet-peer-dependency-sinon?utm_campaign=plugin&utm_content=tracker%2F22069&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F22069&utm_medium=issues&utm_source=github).
@SergioCrisostomo

This comment has been minimized.

Copy link
Member

commented Feb 7, 2016

@olvlvl do the specs run?
I can reproduce the warning but specs do run for me.

We need to update the Karma family dependencies to get these warnings fixed.

@olvlvl

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2016

After installing sinon the specs run fine.

@SergioCrisostomo

This comment has been minimized.

Copy link
Member

commented Feb 7, 2016

@olvlvl ok. Thanks for reporting this. If you have the fix ready welcome to send it. Otherwise we need to review this probably together with the Grunt re-organization Core received.

@arian

This comment has been minimized.

Copy link
Member

commented Feb 15, 2016

npm install sinon --save-dev

karma-sinon defines a peerDependency, meaning that if you use karma-sinon, you need to have a sinon installed as well. npm changed how it handles peerDependencies in version 2 or 3. (MooTools More Travis config still uses old node 0.10).

@olvlvl olvlvl closed this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.