Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixes onComplete/chaining in toElementEdge + toElementCenter #1017

Open
wants to merge 1 commit into from

2 participants

William Meleyal Sergio Crisostomo
William Meleyal

No description provided.

William Meleyal

fixes #1016

William Meleyal

bump

Sergio Crisostomo SergioCrisostomo commented on the diff
Source/Fx/Fx.Scroll.js
@@ -135,7 +135,7 @@ Fx.Scroll = new Class({
if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
}, this);
- if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y);
+ this.start(to.x, to.y);
Sergio Crisostomo Collaborator

@meleyal Could you fix the indent here and under?
We are reviewing all PR's before release of 1.5 and this one seems like a good idea.

PS.- sorry this got forgotten in the PR queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Sergio Crisostomo
Collaborator

@meleyal could you please adapt this jsFiddle to show the problem you describe?
http://jsfiddle.net/6B5eK/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 Source/Fx/Fx.Scroll.js
4 Source/Fx/Fx.Scroll.js
View
@@ -135,7 +135,7 @@ Fx.Scroll = new Class({
if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
}, this);
- if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y);
+ this.start(to.x, to.y);
Sergio Crisostomo Collaborator

@meleyal Could you fix the indent here and under?
We are reviewing all PR's before release of 1.5 and this one seems like a good idea.

PS.- sorry this got forgotten in the PR queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
return this;
},
@@ -156,7 +156,7 @@ Fx.Scroll = new Class({
if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
}, this);
- if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y);
+ this.start(to.x, to.y);
return this;
}
Something went wrong with that request. Please try again.