Skip to content

Loading…

Fixes onComplete/chaining in toElementEdge + toElementCenter #1017

Closed
wants to merge 1 commit into from

2 participants

@meleyal

No description provided.

@meleyal

fixes #1016

@meleyal

bump

@SergioCrisostomo SergioCrisostomo commented on the diff
Source/Fx/Fx.Scroll.js
@@ -135,7 +135,7 @@ Fx.Scroll = new Class({
if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
}, this);
- if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y);
+ this.start(to.x, to.y);
@SergioCrisostomo MooTools member

@meleyal Could you fix the indent here and under?
We are reviewing all PR's before release of 1.5 and this one seems like a good idea.

PS.- sorry this got forgotten in the PR queue

@meleyal
meleyal added a note

Fixed in a new PR here: #1317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@SergioCrisostomo
MooTools member

@meleyal could you please adapt this jsFiddle to show the problem you describe?
http://jsfiddle.net/6B5eK/

@SergioCrisostomo SergioCrisostomo self-assigned this
@meleyal meleyal closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 Source/Fx/Fx.Scroll.js
View
4 Source/Fx/Fx.Scroll.js
@@ -135,7 +135,7 @@ Fx.Scroll = new Class({
if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
}, this);
- if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y);
+ this.start(to.x, to.y);
@SergioCrisostomo MooTools member

@meleyal Could you fix the indent here and under?
We are reviewing all PR's before release of 1.5 and this one seems like a good idea.

PS.- sorry this got forgotten in the PR queue

@meleyal
meleyal added a note

Fixed in a new PR here: #1317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
return this;
},
@@ -156,7 +156,7 @@ Fx.Scroll = new Class({
if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
}, this);
- if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y);
+ this.start(to.x, to.y);
return this;
}
Something went wrong with that request. Please try again.