Skip to content
This repository

Fixes onComplete/chaining in toElementEdge + toElementCenter #1017

Open
wants to merge 1 commit into from

2 participants

Sergio Crisostomo

No description provided.

fixes #1016

bump

Sergio Crisostomo SergioCrisostomo commented on the diff
Source/Fx/Fx.Scroll.js
@@ -135,7 +135,7 @@ Fx.Scroll = new Class({
135 135 if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
136 136 }, this);
137 137
138   - if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y);
  138 + this.start(to.x, to.y);
1
Sergio Crisostomo Collaborator

@meleyal Could you fix the indent here and under?
We are reviewing all PR's before release of 1.5 and this one seems like a good idea.

PS.- sorry this got forgotten in the PR queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Sergio Crisostomo
Collaborator

@meleyal could you please adapt this jsFiddle to show the problem you describe?
http://jsfiddle.net/6B5eK/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Aug 23, 2011
meleyal Fixes onComplete/chaining in toElementEdge + toElementCenter a10e3b7
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 2 additions and 2 deletions. Show diff stats Hide diff stats

  1. +2 2 Source/Fx/Fx.Scroll.js
4 Source/Fx/Fx.Scroll.js
@@ -135,7 +135,7 @@ Fx.Scroll = new Class({
135 135 if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
136 136 }, this);
137 137
138   - if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y);
  138 + this.start(to.x, to.y);
139 139 return this;
140 140 },
141 141
@@ -156,7 +156,7 @@ Fx.Scroll = new Class({
156 156 if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
157 157 }, this);
158 158
159   - if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y);
  159 + this.start(to.x, to.y);
160 160 return this;
161 161 }
162 162

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.