Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Inconsistent normalization mapping of German umlauts #1144

Merged
merged 1 commit into from

3 participants

Martin Donath Arian Stolwijk Sergio Crisostomo
Martin Donath

Hey guys,

String.normalize/1 behaves inconsistently when normalizing German umlauts to ASCII:

ä -> a
ö -> o
ü -> ue

The same holds true for the uppercase equivalents of those characters. Hoping to speak on behalf of all German MooTools developers, I suggest the following mapping:

ä -> a
ö -> o
ü -> u

I would be very happy, if this little fix would make into mootools-more.

Best regards,
Martin

Arian Stolwijk
Owner

:+1:

Sergio Crisostomo SergioCrisostomo merged commit c8082c5 into from
Sergio Crisostomo
Collaborator

@squidfunk Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 4 deletions.
  1. +2 −4 Source/Types/String.Extras.js
6 Source/Types/String.Extras.js
View
@@ -51,10 +51,8 @@ var special = {
'S': /[ŠŞŚ]/g,
't': /[ťţ]/g,
'T': /[ŤŢ]/g,
- 'ue': /[ü]/g,
- 'UE': /[Ü]/g,
- 'u': /[ùúûůµ]/g,
- 'U': /[ÙÚÛŮ]/g,
+ 'u': /[ùúûůüµ]/g,
+ 'U': /[ÙÚÛŮÜ]/g,
'y': /[ÿý]/g,
'Y': /[ŸÝ]/g,
'z': /[žźż]/g,
Something went wrong with that request. Please try again.