Fix for Issue #1159 #1180

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@tomahim
Contributor

tomahim commented Feb 19, 2013

Solution based on what is done on the Sortable class. Fixes #1159

@SergioCrisostomo

This comment has been minimized.

Show comment Hide comment
@SergioCrisostomo

SergioCrisostomo Oct 25, 2015

Member

lgtm. @arian @anutron can I merge this?

Member

SergioCrisostomo commented Oct 25, 2015

lgtm. @arian @anutron can I merge this?

@arian

This comment has been minimized.

Show comment Hide comment
@arian

arian Oct 25, 2015

Owner

Yes, seems ok, maybe some tests would be nice.

Owner

arian commented Oct 25, 2015

Yes, seems ok, maybe some tests would be nice.

@SergioCrisostomo

This comment has been minimized.

Show comment Hide comment
@SergioCrisostomo

SergioCrisostomo Oct 25, 2015

Member
@anutron

This comment has been minimized.

Show comment Hide comment
@anutron

anutron Oct 27, 2015

Owner

Looks good to me. As a side note, I'd put the conditional on one line. We don't break lines like that in MooTools.

Owner

anutron commented Oct 27, 2015

Looks good to me. As a side note, I'd put the conditional on one line. We don't break lines like that in MooTools.

@SergioCrisostomo

This comment has been minimized.

Show comment Hide comment
@SergioCrisostomo

SergioCrisostomo Oct 27, 2015

Member

Fixed in fa1acb1

Member

SergioCrisostomo commented Oct 27, 2015

Fixed in fa1acb1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment