Conversation
|
This is pretty solid work ickata. Now we have to decide if we want to release it. There's a cost to adding things to the library - we have to maintain them. I'll discuss w/ the development team what we want to do. Regardless, thanks for the contribution! |
|
Thanks, Aaron. I just pushed 2 fixes - indentation correction and a typo. |
|
What does that mean? The unit tests failed or what? |
|
@ickata looks like so. Here is the Travis report. Did you run the specs locally before? If not you could check these steps to install the specs runner. Cheers |
|
Thanks for the info. Now everything should pass. BTW - at my company we use MooTools, our website builder is built on top of it, so I will help with the support of everything I push. |
|
Hm, fails again.. Tests pass on my side |
|
Yeah, that's because of mootools/mootools-core#2655 |
|
@ickata we changed back the Node version in the specs. Could you rebase your pull request please, check also the coding style convention to remove extra spaces, and add a empty line in the end of each new file. I just tested your code in my Travis account and got green. Nice work! |
|
Sergio, I made the code follow MooTools' coding guidelines. |
|
Rebased, pushed, but build fails again... |
|
Travis is not perfect. Just checked and all builds passed but one. Sent from my iPhone On 27 sep 2014, at 11:27, Hristo Chakarov notifications@github.com wrote: Rebased, pushed, but build fails again... — |
|
💥 It's been ages since More got a new feature. Congratulations! |
|
We will keep them coming ;) |
|
To the extent that UI stuff is interesting to you, this may also interest you: http://www.behaviorui.com |
4 participants
This is implementation of a class which always returns the same instance when instantiated.
Use it the same way as you use Class.