Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class.Singleton #1285

Merged
merged 5 commits into from Sep 29, 2014
Merged

Class.Singleton #1285

merged 5 commits into from Sep 29, 2014

Conversation

@ickata
Copy link

ickata commented Sep 24, 2014

This is implementation of a class which always returns the same instance when instantiated.

Use it the same way as you use Class.

@anutron
Copy link
Member

anutron commented Sep 24, 2014

This is pretty solid work ickata. Now we have to decide if we want to release it. There's a cost to adding things to the library - we have to maintain them. I'll discuss w/ the development team what we want to do. Regardless, thanks for the contribution!

@ickata
Copy link
Author

ickata commented Sep 24, 2014

Thanks, Aaron. I just pushed 2 fixes - indentation correction and a typo.

@ickata
Copy link
Author

ickata commented Sep 25, 2014

What does that mean? The unit tests failed or what?

@SergioCrisostomo
Copy link
Member

SergioCrisostomo commented Sep 25, 2014

@ickata looks like so. Here is the Travis report.

Did you run the specs locally before? If not you could check these steps to install the specs runner.

Cheers

@ickata
Copy link
Author

ickata commented Sep 25, 2014

Thanks for the info. Now everything should pass.

BTW - at my company we use MooTools, our website builder is built on top of it, so I will help with the support of everything I push.

@ickata
Copy link
Author

ickata commented Sep 25, 2014

Hm, fails again.. Tests pass on my side

@arian
Copy link
Member

arian commented Sep 25, 2014

Yeah, that's because of mootools/mootools-core#2655

@SergioCrisostomo
Copy link
Member

SergioCrisostomo commented Sep 25, 2014

@ickata we changed back the Node version in the specs. Could you rebase your pull request please, check also the coding style convention to remove extra spaces, and add a empty line in the end of each new file.

I just tested your code in my Travis account and got green.

Nice work!

@ickata
Copy link
Author

ickata commented Sep 27, 2014

Sergio, I made the code follow MooTools' coding guidelines.

@ickata ickata force-pushed the ickata:master branch from 5fad6f9 to 01846ad Sep 27, 2014
@ickata
Copy link
Author

ickata commented Sep 27, 2014

Rebased, pushed, but build fails again...

@SergioCrisostomo
Copy link
Member

SergioCrisostomo commented Sep 27, 2014

Travis is not perfect. Just checked and all builds passed but one.
Re-started it. I think it will pass.

Sent from my iPhone

On 27 sep 2014, at 11:27, Hristo Chakarov notifications@github.com wrote:

Rebased, pushed, but build fails again...


Reply to this email directly or view it on GitHub
#1285 (comment).

SergioCrisostomo added a commit that referenced this pull request Sep 29, 2014
Class.Singleton
@SergioCrisostomo SergioCrisostomo merged commit 1105475 into mootools:master Sep 29, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@anutron
Copy link
Member

anutron commented Sep 29, 2014

💥

It's been ages since More got a new feature. Congratulations!

@ickata
Copy link
Author

ickata commented Sep 29, 2014

We will keep them coming ;)

@anutron
Copy link
Member

anutron commented Sep 29, 2014

To the extent that UI stuff is interesting to you, this may also interest you: http://www.behaviorui.com

@mootools mootools deleted a comment Aug 2, 2017
@mootools mootools deleted a comment Feb 13, 2019
@mootools mootools deleted a comment from AnglinaMiller Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.