Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show empty tooltips #1299

Merged
merged 3 commits into from Feb 16, 2015
Merged

Don't show empty tooltips #1299

merged 3 commits into from Feb 16, 2015

Conversation

muffinmad
Copy link
Contributor

Also make tooltip hidden on creation.
Fixing this issue

@SergioCrisostomo SergioCrisostomo added this to the 1.5.2 milestone Jan 15, 2015
@SergioCrisostomo
Copy link
Member

@muffinmad nice work!

👍

@@ -170,15 +172,22 @@ this.Tips = new Class({
clearTimeout(this.timer);
this.timer = (function(){
this.container.empty();

var showTip = !this.options.hideEmpty;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for shipping this, but you declare this variable just to reference it once in a conditional; I'd remove this line and reference the option directly on line 186.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this. I see line 183...

arian added a commit that referenced this pull request Feb 16, 2015
Don't show empty tooltips - fixes #1298
@arian arian merged commit 7d556a0 into mootools:master Feb 16, 2015
@mootools mootools deleted a comment Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants