URI.regex | Added IPv6 compatibility #1322

Merged
merged 3 commits into from Sep 27, 2015

Projects

None yet

5 participants

@boppy
Contributor
boppy commented Sep 26, 2015

Related to: #1318

Added basic recognition of IPv6 addresses to the regex by adding a second option the the host-part of the regex (starting with index 66+18 byte).
Does not check syntax anyhow. Only checking for "[", "]" wrapping "any mass off" [a-fA-F0-9:].

boppy added some commits Sep 26, 2015
@boppy boppy Added IPv6 compatibility to URI.regex
Added basic recognition of IPv6 addresses to the regex by adding a second option the the host-part of the regex (starting with index 66+18 byte).
Does not check syntax anyhow. Only checking for "[", "]" wrapping "any mass off" [a-fA-F0-9:].
7c142bc
@boppy boppy Added tests for ipv6 recognition
With code by @SergioCrisostomo
d5d6a49
@boppy boppy Fixed Coding style to apply to guidelines f872370
@arian
Member
arian commented Sep 27, 2015

This looks very nice!

@timwienk
Member

👍

Small change, does exactly what it should (syntax checking the IPv6 address would make it too slow for hardly any benefit). I can imagine it was not fun figuring the regex out, though. Thanks for adding the test as well.

Also ++ on the style fix commit.

@SergioCrisostomo SergioCrisostomo merged commit 9b612fe into mootools:master Sep 27, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ngosang
ngosang commented Sep 28, 2015

Thanks.

@ngosang ngosang referenced this pull request in qbittorrent/qBittorrent Nov 9, 2015
Merged

[WebUI] Patch mootools-more to fix IPv6 problem. Closes #3621 #4094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment