New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI.regex | Added IPv6 compatibility #1322

Merged
merged 3 commits into from Sep 27, 2015

Conversation

Projects
None yet
5 participants
@boppy
Contributor

boppy commented Sep 26, 2015

Related to: #1318

Added basic recognition of IPv6 addresses to the regex by adding a second option the the host-part of the regex (starting with index 66+18 byte).
Does not check syntax anyhow. Only checking for "[", "]" wrapping "any mass off" [a-fA-F0-9:].

boppy added some commits Sep 26, 2015

Added IPv6 compatibility to URI.regex
Added basic recognition of IPv6 addresses to the regex by adding a second option the the host-part of the regex (starting with index 66+18 byte).
Does not check syntax anyhow. Only checking for "[", "]" wrapping "any mass off" [a-fA-F0-9:].
@arian

This comment has been minimized.

Show comment
Hide comment
@arian

arian Sep 27, 2015

Member

This looks very nice!

Member

arian commented Sep 27, 2015

This looks very nice!

@timwienk

This comment has been minimized.

Show comment
Hide comment
@timwienk

timwienk Sep 27, 2015

Member

👍

Small change, does exactly what it should (syntax checking the IPv6 address would make it too slow for hardly any benefit). I can imagine it was not fun figuring the regex out, though. Thanks for adding the test as well.

Also ++ on the style fix commit.

Member

timwienk commented Sep 27, 2015

👍

Small change, does exactly what it should (syntax checking the IPv6 address would make it too slow for hardly any benefit). I can imagine it was not fun figuring the regex out, though. Thanks for adding the test as well.

Also ++ on the style fix commit.

SergioCrisostomo added a commit that referenced this pull request Sep 27, 2015

Merge pull request #1322 from boppy/master
URI.regex | Added IPv6 compatibility

@SergioCrisostomo SergioCrisostomo merged commit 9b612fe into mootools:master Sep 27, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ngosang

This comment has been minimized.

Show comment
Hide comment
@ngosang

ngosang commented Sep 28, 2015

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment