Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI.regex | Added IPv6 compatibility #1322

Merged
merged 3 commits into from Sep 27, 2015
Merged

Conversation

@boppy
Copy link
Contributor

boppy commented Sep 26, 2015

Related to: #1318

Added basic recognition of IPv6 addresses to the regex by adding a second option the the host-part of the regex (starting with index 66+18 byte).
Does not check syntax anyhow. Only checking for "[", "]" wrapping "any mass off" [a-fA-F0-9:].

boppy added 3 commits Sep 26, 2015
Added basic recognition of IPv6 addresses to the regex by adding a second option the the host-part of the regex (starting with index 66+18 byte).
Does not check syntax anyhow. Only checking for "[", "]" wrapping "any mass off" [a-fA-F0-9:].
With code by @SergioCrisostomo
@arian
Copy link
Member

arian commented Sep 27, 2015

This looks very nice!

@timwienk
Copy link
Member

timwienk commented Sep 27, 2015

👍

Small change, does exactly what it should (syntax checking the IPv6 address would make it too slow for hardly any benefit). I can imagine it was not fun figuring the regex out, though. Thanks for adding the test as well.

Also ++ on the style fix commit.

SergioCrisostomo added a commit that referenced this pull request Sep 27, 2015
URI.regex | Added IPv6 compatibility
@SergioCrisostomo SergioCrisostomo merged commit 9b612fe into mootools:master Sep 27, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ngosang
Copy link

ngosang commented Sep 28, 2015

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.