Add ESLint, code stye polish #1327

Merged
merged 2 commits into from Nov 6, 2015

Projects

None yet

5 participants

@SergioCrisostomo
Member

No description provided.

@arian arian commented on an outdated diff Oct 20, 2015
Tests/eslint-configure/eslint.json
@@ -0,0 +1,14 @@
+{
+ "rules": {
+ "no-alert": 2,
+ "no-console": 0,
+ "curly": 0,
+ "eqeqeq": 0,
+ "eqnull": 0,
+ "nonew": 0,
+ "camelcase": 0,
+ "semi": 2,
+ "no-trailing-spaces": 2,
+ "whitespace-mootools-codestyle" : 2
+ }
+}
@arian
arian Oct 20, 2015 Member

Check the codestyle of this json file (indentation) ;)

@arian arian commented on an outdated diff Oct 20, 2015
Tests/eslint-configure/rules/no-alert.js
@@ -0,0 +1,10 @@
+'use strict';
+module.exports = function (context){
+ return {
+ CallExpression: function (node){
+ if (node.callee.name === 'alert'){
+ context.report(node, 'No alert in source code please.');
+ }
+ }
+ };
+};
@arian
arian Oct 20, 2015 Member

Why have this rule here?

@arian arian commented on an outdated diff Oct 20, 2015
@@ -8,6 +8,14 @@ module.exports = function(grunt) {
var pullRequest = process.env.TRAVIS_PULL_REQUEST;
grunt.initConfig({
+ eslint: {
@arian
arian Oct 20, 2015 Member

tabs/spaces.

@arian arian commented on an outdated diff Oct 20, 2015
@@ -8,6 +8,14 @@ module.exports = function(grunt) {
var pullRequest = process.env.TRAVIS_PULL_REQUEST;
grunt.initConfig({
+ eslint: {
+ target: ['Source/**/*.js'],
@arian
arian Oct 20, 2015 Member

I'd add Gruntfile.js, Tests/**/*.js

@anutron
Member
anutron commented Oct 20, 2015

I'm going to get crucified for this, but it's 2015. Can we please switch to spaces for indentation now?

@timwienk
Member

No.

It's 2015, there are more programmers and editors out there than ever, with more preferences than ever. No need to force a specific indentation width on anyone.

@arian
Member
arian commented Oct 20, 2015

and the ) { space too?

@anutron
Member
anutron commented Oct 20, 2015

Github is the normalizer here. It treats tabs as 4 spaces. Editors are smart enough that we - programmers - don't even notice which one it is. But gitub does. It makes all our lines longer than the width of the column here.

@arian arian commented on an outdated diff Oct 20, 2015
@@ -8,6 +8,14 @@ module.exports = function(grunt) {
var pullRequest = process.env.TRAVIS_PULL_REQUEST;
grunt.initConfig({
+ eslint: {
+ target: ['Source/**/*.js'],
+ options: {
+ configFile: 'Tests/eslint-configure/eslint.json',
@arian
arian Oct 20, 2015 Member

If you use .eslintrc, the file is automatically picked up by the command line tool, which is useful for editor plugins for example.

@timwienk
Member

and the ) { space too?

That thing I never really cared about, that's been there because Valerio once upon a time decided he liked it. It's just been moo style since the start.

Github is the normalizer here.

Then perhaps Github should be configurable for this as well. I'm sure they accept Pull Requests. 😉

Editors are smart enough that we - programmers - don't even notice which one it is.

That makes no sense, in an editor you can obviously change tabspace, but no one in their right mind is going to change space-space.

@timwienk
Member

Either way, let's leave this indentation discussion out of this PR.

@SergioCrisostomo
Member

Updated! I will send a similar PR to Core also.

@SergioCrisostomo
Member

Can we merge this? or any review/comments/change missing?

@kentaromiura
Member

@anutron if it's what bother you, just add ?ts=2 at the end of the file you're reviewing, there are also browser extension that do this to all the files :)

@kentaromiura kentaromiura merged commit 01b2352 into mootools:master Nov 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SergioCrisostomo SergioCrisostomo deleted the SergioCrisostomo:eslint branch Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment