Add ESLint, code stye polish

[SergioCrisostomo]

No description provided.

[arian]

Check the codestyle of this json file (indentation) ;)

[anutron]

I'm going to get crucified for this, but it's 2015. Can we please switch to spaces for indentation now?

[timwienk]

No.

It's 2015, there are more programmers and editors out there than ever, with more preferences than ever. No need to force a specific indentation width on anyone.

[arian]

and the ) { space too?

[anutron]

Github is the normalizer here. It treats tabs as 4 spaces. Editors are smart enough that we - programmers - don't even notice which one it is. But gitub does. It makes all our lines longer than the width of the column here.

[arian]

If you use .eslintrc, the file is automatically picked up by the command line tool, which is useful for editor plugins for example.

[timwienk]

and the ) { space too?

That thing I never really cared about, that's been there because Valerio once upon a time decided he liked it. It's just been moo style since the start.

Github is the normalizer here.

Then perhaps Github should be configurable for this as well. I'm sure they accept Pull Requests. 😉

Editors are smart enough that we - programmers - don't even notice which one it is.

That makes no sense, in an editor you can obviously change tabspace, but no one in their right mind is going to change space-space.

[timwienk]

Either way, let's leave this indentation discussion out of this PR.

[SergioCrisostomo]

Updated! I will send a similar PR to Core also.

[SergioCrisostomo]

Can we merge this? or any review/comments/change missing?

[kentaromiura]

@anutron if it's what bother you, just add ?ts=2 at the end of the file you're reviewing, there are also browser extension that do this to all the files :)