Fix #1188 #1329

Merged
merged 2 commits into from Oct 27, 2015

Projects

None yet

2 participants

@SergioCrisostomo
Member

Squashed the existing 4 commits, rebased, and added my own adressing what @anutron pointed out:

  • avoid .getElements() to get called over null when document.id() doesn't find a element
  • code style, spaces

closes #1188

ntom and others added some commits Mar 7, 2013
@SergioCrisostomo ntom Update Form.Validator.Extras.js
Bugfix to validate-reqchk-byname - not hiding error messages properly when one checkbox is unchecked, producing an eror underneath it, then another checkbox is checked, and the previous error doesn't go away.
example: http://jsfiddle.net/aUFe4/1/

Update Form.Validator.Extras.js

Bugfix to validate-reqchk-byname - not hiding error messages properly when one checkbox is unchecked, producing an eror underneath it, then another checkbox is checked, and the previous error doesn't go away.
example: http://jsfiddle.net/aUFe4/1/

Added feature validate-enforce-onselect-value

validate-enforce-onselect-value - enables the user to specify when a select value is selected, to enforce / ignore fields

remove some unessential code + tab indent cleanup

remove some unessential code + tab indent cleanup
670f4b1
@SergioCrisostomo SergioCrisostomo avoid calling getElements of null
also clean up spaces
0b8871f
@SergioCrisostomo
Member

@anutron this is basically what you had already reviewed plus 1 commit from me adressing what you asked for.

If you (or someone else) can review my commit then we can merge this.

@anutron
Member
anutron commented Oct 27, 2015

Yeah, this is good. Big props to @ntom on this PR from so long ago. Sorry the project is so slow these days.

@anutron
Member
anutron commented Oct 27, 2015

Ship it.

@SergioCrisostomo SergioCrisostomo merged commit f5a1884 into mootools:master Oct 27, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SergioCrisostomo SergioCrisostomo deleted the SergioCrisostomo:squash-1188 branch Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment