Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1188 #1329

Merged
merged 2 commits into from Oct 27, 2015
Merged

Fix #1188 #1329

merged 2 commits into from Oct 27, 2015

Conversation

@SergioCrisostomo
Copy link
Member

SergioCrisostomo commented Oct 25, 2015

Squashed the existing 4 commits, rebased, and added my own adressing what @anutron pointed out:

  • avoid .getElements() to get called over null when document.id() doesn't find a element
  • code style, spaces

closes #1188

ntom and others added 2 commits Mar 7, 2013
Bugfix to validate-reqchk-byname - not hiding error messages properly when one checkbox is unchecked, producing an eror underneath it, then another checkbox is checked, and the previous error doesn't go away.
example: http://jsfiddle.net/aUFe4/1/

Update Form.Validator.Extras.js

Bugfix to validate-reqchk-byname - not hiding error messages properly when one checkbox is unchecked, producing an eror underneath it, then another checkbox is checked, and the previous error doesn't go away.
example: http://jsfiddle.net/aUFe4/1/

Added feature validate-enforce-onselect-value

validate-enforce-onselect-value - enables the user to specify when a select value is selected, to enforce / ignore fields

remove some unessential code + tab indent cleanup

remove some unessential code + tab indent cleanup
also clean up spaces
@SergioCrisostomo
Copy link
Member Author

SergioCrisostomo commented Oct 25, 2015

@anutron this is basically what you had already reviewed plus 1 commit from me adressing what you asked for.

If you (or someone else) can review my commit then we can merge this.

@anutron
Copy link
Member

anutron commented Oct 27, 2015

Yeah, this is good. Big props to @NTOM on this PR from so long ago. Sorry the project is so slow these days.

@anutron
Copy link
Member

anutron commented Oct 27, 2015

Ship it.

SergioCrisostomo added a commit that referenced this pull request Oct 27, 2015
Bugfix to validate-reqchk-byname #1188
@SergioCrisostomo SergioCrisostomo merged commit f5a1884 into mootools:master Oct 27, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SergioCrisostomo SergioCrisostomo deleted the SergioCrisostomo:squash-1188 branch Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.