New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new option "keepOpen" to Fx.Accordion #1333

Merged
merged 2 commits into from Nov 2, 2015

Conversation

Projects
None yet
3 participants
@SergioCrisostomo
Member

SergioCrisostomo commented Nov 2, 2015

Adds a new option keepOpen - (boolean; defaults to false). If set to true, it will keep multiple elements open (no auto collapsing). To close a element you have to "click" the trigger again.

docs and specs included

replaces #1187

SunboX and others added some commits Mar 6, 2013

Keep multiple elements open, only close on "click"
Added new config option "keepOpen" to keep multiple elements open (no auto collapsing). To close a element you have to "click" the trigger again.
Defaults to "false", so this won´t be a breaking change.
@anutron

This comment has been minimized.

Show comment
Hide comment
@anutron

anutron Nov 2, 2015

Member

Code looks ok I guess, but the specs failed.

Member

anutron commented Nov 2, 2015

Code looks ok I guess, but the specs failed.

@SergioCrisostomo

This comment has been minimized.

Show comment
Hide comment
@SergioCrisostomo

SergioCrisostomo Nov 2, 2015

Member

@anutron yeah, Travis is not perfect :) Restarted the failed test and now passed.
If you want you can press the green button :)

Member

SergioCrisostomo commented Nov 2, 2015

@anutron yeah, Travis is not perfect :) Restarted the failed test and now passed.
If you want you can press the green button :)

@anutron

This comment has been minimized.

Show comment
Hide comment
@anutron

anutron Nov 2, 2015

Member

you can push it. ship it.

Member

anutron commented Nov 2, 2015

you can push it. ship it.

SergioCrisostomo added a commit that referenced this pull request Nov 2, 2015

Merge pull request #1333 from SergioCrisostomo/pr1187
new option "keepOpen" to Fx.Accordion

@SergioCrisostomo SergioCrisostomo merged commit ad17ac4 into mootools:master Nov 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SergioCrisostomo

This comment has been minimized.

Show comment
Hide comment
@SergioCrisostomo

SergioCrisostomo Nov 2, 2015

Member

anutron 👍

Member

SergioCrisostomo commented Nov 2, 2015

anutron 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment