Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix for #572 Fx.Slide not working properly on absolute-positioned elements #244

Closed
wants to merge 1 commit into from

3 participants

@arian
Owner

Could you give an code example (jsfiddle) where this failed? Then I'll probably pull it, and add that code as an test.

@Savageman

Sure. http://jsfiddle.net/qWs9d/
Try to remove the position:absolute in the CSS to see it working.

Opera also needs the width which is currently not included in the pull request... Not sure why. This also means that the height could be an issue when sliding horizontally...

@arian
Owner

I tend to say to not fix this in Fx.Slide, but rather use a wrapper in the html (or wrap it yourself with js). There are so many cases with absolute positioning, fixed positioning, overflows etc. It's much easier to handle that in a parent element.

@SergioCrisostomo
Collaborator

I agree with Arian, it would be better to use a wrapper like http://jsfiddle.net/Phys2/.
I close this now. @Savageman thank you for bringing this up and do comment back if you think I missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 18, 2011
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  Source/Fx/Fx.Slide.js
View
2  Source/Fx/Fx.Slide.js
@@ -39,7 +39,7 @@ Fx.Slide = new Class({
options = this.options;
var wrapper = element.retrieve('wrapper'),
- styles = element.getStyles('margin', 'position', 'overflow');
+ styles = element.getStyles('margin', 'position', 'overflow', 'top', 'right', 'bottom', 'left');
if (options.hideOverflow) styles = Object.append(styles, {overflow: 'hidden'});
if (options.wrapper) wrapper = document.id(options.wrapper).setStyles(styles);
Something went wrong with that request. Please try again.