Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

compareDocumentPosition(null) throws NS_ERROR_ILLEGAL_VALUE in older versions of Firefox 5 #68

Open
barryvan opened this Issue · 1 comment

2 participants

@barryvan

Found in Firefox 5 (one of our clients standardised on it).

Slick.Finder.js, line 217
context.compareDocumentPosition throws NS_ERROR_ILLEGAL_VALUE when passed null. Simply adding in "if (node === null) return false;" fixes the problem for me. Should I make a pull request?

@fabiomcosta
Collaborator

Do you have an example of that? I think the problem is not in this method, but at the moment we pass null to it, we shouldn't be passing null to it. If you could help with a jsfiddle or something, would be awesome!

Thanks!

@fabiomcosta fabiomcosta was assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.