Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

compareDocumentPosition(null) throws NS_ERROR_ILLEGAL_VALUE in older versions of Firefox 5 #68

Open
barryvan opened this Issue Feb 27, 2012 · 1 comment

Comments

Projects
None yet
2 participants

Found in Firefox 5 (one of our clients standardised on it).

Slick.Finder.js, line 217
context.compareDocumentPosition throws NS_ERROR_ILLEGAL_VALUE when passed null. Simply adding in "if (node === null) return false;" fixes the problem for me. Should I make a pull request?

Member

fabiomcosta commented Mar 12, 2012

Do you have an example of that? I think the problem is not in this method, but at the moment we pass null to it, we shouldn't be passing null to it. If you could help with a jsfiddle or something, would be awesome!

Thanks!

@ghost ghost assigned fabiomcosta Mar 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment