Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add https://github.com/ccoveille/go-safecast to fix int casting errorsImpact may be slightly breaking for casting in telemetry span attributes.Specifically, if casting int fails, we fallback to setting the span attribute as a string using formatting rather than dropping the span attribute.Pro of fallback: is we don't drop the span attribute no matter what.Con of fallback: is querying span attributes may break given type changeSee e18436cAdd
//nolint:gosecto resolve lint errors for casting intAdd
//nolint:sqlclosecheckto resolve lint errors given the lint failures are around wrapping database/sql methods. i.e. we're not supposed to close those.