cmd/server: files: test validating an invalid file

moov-io · Aug 19, 2019 · c0ba118 · c0ba118
1 parent 90c0fb2
commit c0ba118
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/cmd/server/files_test.go b/cmd/server/files_test.go
@@ -296,9 +296,18 @@ func TestFiles__validateFile(t *testing.T) {
 		t.Errorf("unexpected body: %v", w.Body.String())
 	}
 
-	// error case
-	repo.err = errors.New("bad error")
+	// make the file invalid
+	repo.file.Header = imagecashletter.NewFileHeader()
+	w = httptest.NewRecorder()
+	router.ServeHTTP(w, req)
+	w.Flush()
 
+	if w.Code != http.StatusBadRequest {
+		t.Errorf("bogus HTTP status: %d: %v", w.Code, w.Body.String())
+	}
+
+	// repository error case
+	repo.err = errors.New("bad error")
 	w = httptest.NewRecorder()
 	router.ServeHTTP(w, req)
 	w.Flush()