Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Namespace support #18

Closed
jhinrichsen opened this Issue · 6 comments

5 participants

@jhinrichsen

Dear team,

thanks for the great library. It nicely solves my xml problem that involves processing xml in an unknown format.

After having a closer look at the sources, i find that namespace support is not available for attributes. I'm thinking about implementing this missing piece - unless you are already in the middle of doing so.

Thanks for your feedback

Jochen

@jhinrichsen

A draft implementation is happily humming along. I do not have a clean pull request at hand, because in addition to the namespace extension i had to (1) change include path for darwin/x64 and (2) remove any reference to time/ Deadline related code that i found broke.

Please feel free to have a look at the new ns.go file (not sure if all the interface stuff is needed, i just borrowed heavily from Node/ XmlNode), the new function in node.go, and the new testcase in attribute_test.go.

The change should be transparent to existing clients.

@zhigangc

Thanks for your contribution, Jochen. I will review it and get back to you.

Yes, the Deadline related code was intended for internal use. I will create a separate public repo very soon.

@rzymek

Any news of the subject?
I've just stumbled upon the lack of AttributeNode.Namespace() while writing an Inkscape SVG cleaner.

@mdayaram

Sorry, the project has been passed to different hands, so this issue was lost in the wayside. Regardless, I don't think there's any future plans for implementing namespace support for attributes from our side. However, if @jhinrichsen has a PR ready, I'll gladly look at it and merge it if it's good to go.

@jbowtie

This looks to have been fixed by pull requests #37 and #38

@mdayaram

True that. @rzymek, does the new Namespace API meet your needs?

@mdayaram mdayaram closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.