Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Recursive remove of headers #22

Merged
merged 6 commits into from

3 participants

@mattkanwisher

Tryng this again, the tests were broken cause master has broken references to libxml making it very difficult to test :(

elimisteve and others added some commits
@elimisteve elimisteve Fixed type ('Fragement' -> 'Fragment') 24c215e
Zhigang Chen Merge pull request #21 from elimisteve/patch-1
Fixed typo ('Fragement' -> 'Fragment')
f2e42bf
Zhigang Chen Merge pull request #20 from mattkanwisher/master
Recursive remove of namespaces
bae1ca9
Zhigang Chen test fails
Revert "Merge pull request #20 from mattkanwisher/master"

This reverts commit bae1ca9, reversing
changes made to f2e42bf.
0e5e36c
@mattkanwisher

Seriously dude? I gave you a fix a month ago that fixed the tests, its in your pull requests. I even emailed you the same day on the issue

@mattkanwisher mattkanwisher reopened this
@mdayaram mdayaram merged commit 01a9bc3 into from
@mdayaram

Sorry for the long wait for this. When I tested the PR earlier this week, it was still broken, and before I got a chance to comment, you had closed it already.

We've also had some internal restructuring take place, which was the cause why this fell through the cracks, sorry about that.

Regardless, thanks again for contributing, we really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 11, 2013
  1. @elimisteve
Commits on Mar 18, 2013
  1. Merge pull request #21 from elimisteve/patch-1

    Zhigang Chen authored
    Fixed typo ('Fragement' -> 'Fragment')
  2. Merge pull request #20 from mattkanwisher/master

    Zhigang Chen authored
    Recursive remove of namespaces
  3. test fails

    Zhigang Chen authored
    Revert "Merge pull request #20 from mattkanwisher/master"
    
    This reverts commit bae1ca9, reversing
    changes made to f2e42bf.
Commits on Apr 23, 2013
  1. @mattkanwisher

    Fixing location of test

    mattkanwisher authored
  2. @mattkanwisher
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 36 deletions.
  1. +1 −1  Readme
  2. +0 −2  xml/document.go
  3. +0 −33 xml/node.go
View
2  Readme
@@ -7,7 +7,7 @@ This is a major rewrite from v0 in the following places:
- Separation of XML and HTML
- Put more burden of memory allocation/deallocation on Go
- - Fragement parsing -- no more deep-copy
+ - Fragment parsing -- no more deep-copy
- Serialization
- Some API adjustment
View
2  xml/document.go
@@ -36,8 +36,6 @@ type Document interface {
String() string
Root() *ElementNode
BookkeepFragment(*DocumentFragment)
-
- RecursivelyRemoveNamespaces() error
}
//xml parse option
View
33 xml/node.go
@@ -138,8 +138,6 @@ type Node interface {
String() string
Content() string
InnerHtml() string
-
- RecursivelyRemoveNamespaces() error
}
//run out of memory
@@ -844,34 +842,3 @@ func (xmlNode *XmlNode) isAccestor(nodePtr unsafe.Pointer) int {
}
return 0
}
-
-func (xmlNode *XmlNode) RecursivelyRemoveNamespaces() (err error) {
- nodePtr := xmlNode.Ptr
- C.xmlSetNs(nodePtr, nil)
-
- for child := xmlNode.FirstChild(); child != nil; {
- child.RecursivelyRemoveNamespaces()
- child = child.NextSibling()
- }
-
- nodeType := xmlNode.NodeType()
-
- if ((nodeType == XML_ELEMENT_NODE) ||
- (nodeType == XML_XINCLUDE_START) ||
- (nodeType == XML_XINCLUDE_END)) &&
- (nodePtr.nsDef != nil) {
- C.xmlFreeNsList((*C.xmlNs)(nodePtr.nsDef))
- nodePtr.nsDef = nil
- }
-
- if nodeType == XML_ELEMENT_NODE && nodePtr.properties != nil {
- property := nodePtr.properties
- for property != nil {
- if property.ns != nil {
- property.ns = nil
- }
- property = property.next
- }
- }
- return
-}
Something went wrong with that request. Please try again.