Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for trailing comma in function arguments #454

Merged
merged 1 commit into from Sep 30, 2017
Merged

Add support for trailing comma in function arguments #454

merged 1 commit into from Sep 30, 2017

Conversation

olessavluk
Copy link
Contributor

Fixes #453

I've tested this using make test and also installed patched version locally. For now there are no errors/warnings for this code:

Trailing comma in: import, function declaration/call, array, object, export
import {
  a,
  b,
} from 'package';

function f (
  a,
  b,
) {}

f(
  1,
  2,
);

const array = [
  1,
  2,
];

const object = {
  a,
  b,
};

export {
  a,
  f,
};

@dgutov dgutov merged commit 5cb52a7 into mooz:master Sep 30, 2017
@dgutov
Copy link
Collaborator

dgutov commented Sep 30, 2017

Thanks!

@olessavluk olessavluk deleted the trailing-comma branch September 30, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants