New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrobbled tracks not saving #20

Closed
Firestorrrm opened this Issue Mar 15, 2016 · 10 comments

Comments

8 participants
@Firestorrrm
Copy link

Firestorrrm commented Mar 15, 2016

Whenever a track is playing, it shows on Last.FM, but it doesn't save when it's done playing. Is there any way to fix this?

@wgslr

This comment has been minimized.

Copy link

wgslr commented Mar 28, 2016

I have the same issue.

@jodal jodal added the bug label Mar 28, 2016

@moon-musick

This comment has been minimized.

Copy link

moon-musick commented Apr 6, 2016

It seems I encountered a similar problem - the track is displayed as 'now playing', but only the last track of a playlist is saved.

I use mopidy exclusively with mopidy-spotify.

Software versions (everything from APT repository):

  • mopidy 2.0.0-1
  • mopidy-spotify 3.0.0-0mopidy1
  • mopidy-scrobbler 1.1.1-3
@trygveaa

This comment has been minimized.

Copy link
Member

trygveaa commented Apr 10, 2016

It seems like this is caused by mopidy/mopidy#1456.

We can probably keep this open until that is fixed, and we have confirmed that it fixes this.

@0nse

This comment has been minimized.

Copy link

0nse commented Apr 10, 2016

@trygveaa is right. @moon-musick, as a temporary fix, you can disable the time_position check:

diff --git mopidy_scrobbler/frontend.py.old mopidy_scrobbler/frontend.py
index 6a34d9e..cd47e82 100644
--- mopidy_scrobbler/frontend.py.old
+++ mopidy_scrobbler/frontend.py
@@ -57,14 +57,9 @@ class ScrobblerFrontend(pykka.ThreadingActor, CoreListener):
         track = tl_track.track
         artists = ', '.join(sorted([a.name for a in track.artists]))
         duration = track.length and track.length // 1000 or 0
-        time_position = time_position // 1000
         if duration < 30:
             logger.debug('Track too short to scrobble. (30s)')
             return
-        if time_position < duration // 2 and time_position < 240:
-            logger.debug(
-                'Track not played long enough to scrobble. (50% or 240s)')
-            return
         if self.last_start_time is None:
             self.last_start_time = int(time.time()) - duration
         logger.debug('Scrobbling track: %s - %s', artists, track.name)
@moon-musick

This comment has been minimized.

Copy link

moon-musick commented Apr 10, 2016

@0nse it works perfectly after I applied the fix, thank you!

@hubspek

This comment has been minimized.

Copy link

hubspek commented Jul 15, 2016

that fix leads to fake scrobbles. the track gets scrobbled when you're trying to skip it.

@jjok

This comment has been minimized.

Copy link

jjok commented Jul 15, 2016

@hubspek I think it's just meant as a workaround until the issue with Mopidy is fixed.

@0nse

This comment has been minimized.

Copy link

0nse commented Jul 16, 2016

@hubspek it's not a fix but a temporary workaround. Look at the provided patch; it scrobbels everything disregarding of how long it has been played. If it were a fix, I would have issued a PR.

@hubspek

This comment has been minimized.

Copy link

hubspek commented Jul 16, 2016

@jjok It's been called a fix by @0nse from the beginning and that's why I used the term. I know the difference.

And I stated a fact. That, whatever you call it, leads to FAKE scrobbles. That issue has been open for months now. You should keep focus on that rather than schooling ppl on insignificant details.

@jjok

This comment has been minimized.

Copy link

jjok commented Jul 18, 2016

@hubspek I'm not sure what you mean. Your options are:

  • Use the extension without the patch, which means that nothing scrobbles,
  • Use the extension with the patch, which means that everything scrobbles,
  • Fix the issue in Mopidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment