Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Replace faye-websocket with isomorphic-ws
  • Loading branch information
jodal committed Oct 9, 2018
1 parent e2e2118 commit 703d18b
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 35 deletions.
5 changes: 5 additions & 0 deletions README.md
Expand Up @@ -86,6 +86,11 @@ yarn build
const Mopidy = new Mopidy(...);
```

- Modernized dependencies:

- `isomorphic-ws` and `ws` has replaced our own wrapper around the browser's
`WebSocket` API and `faye-websocket` on Node.

- Modernized development stack:

- Testing: Jest has replaced Buster.JS and Sinon.
Expand Down
1 change: 0 additions & 1 deletion lib/websocket/browser.js

This file was deleted.

4 changes: 0 additions & 4 deletions lib/websocket/package.json

This file was deleted.

1 change: 0 additions & 1 deletion lib/websocket/server.js

This file was deleted.

5 changes: 3 additions & 2 deletions package.json
Expand Up @@ -39,8 +39,9 @@
},
"dependencies": {
"bane": "~1.1.0",
"faye-websocket": "~0.9.2",
"when": "~3.7.2"
"isomorphic-ws": "^4.0.1",
"when": "~3.7.2",
"ws": "^6.1.0"
},
"devDependencies": {
"eslint-config-airbnb-base": "^13.1.0",
Expand Down
4 changes: 2 additions & 2 deletions src/mopidy.js
@@ -1,6 +1,6 @@
const bane = require("bane");
const when = require("when");
const websocket = require("../lib/websocket/");
const WebSocket = require("isomorphic-ws");

class Mopidy {
constructor(settings) {
Expand Down Expand Up @@ -312,7 +312,7 @@ class ServerError extends Error {
}
Mopidy.ServerError = ServerError;

Mopidy.WebSocket = websocket.Client;
Mopidy.WebSocket = WebSocket;

Mopidy.when = when;

Expand Down
37 changes: 12 additions & 25 deletions yarn.lock
Expand Up @@ -2758,13 +2758,6 @@ fast-levenshtein@~2.0.4:
resolved "https://registry.yarnpkg.com/fast-levenshtein/-/fast-levenshtein-2.0.6.tgz#3d8a5c66883a16a30ca8643e851f19baa7797917"
integrity sha1-PYpcZog6FqMMqGQ+hR8Zuqd5eRc=

faye-websocket@~0.9.2:
version "0.9.4"
resolved "https://registry.yarnpkg.com/faye-websocket/-/faye-websocket-0.9.4.tgz#885934c79effb0409549e0c0a3801ed17a40cdad"
integrity sha1-iFk0x57/sECVSeDAo4Ae0XpAza0=
dependencies:
websocket-driver ">=0.5.1"

fb-watchman@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/fb-watchman/-/fb-watchman-2.0.0.tgz#54e9abf7dfa2f26cd9b1636c588c1afc05de5d58"
Expand Down Expand Up @@ -3250,11 +3243,6 @@ http-errors@~1.6.2:
setprototypeof "1.1.0"
statuses ">= 1.4.0 < 2"

http-parser-js@>=0.4.0:
version "0.4.13"
resolved "https://registry.yarnpkg.com/http-parser-js/-/http-parser-js-0.4.13.tgz#3bd6d6fde6e3172c9334c3b33b6c193d80fe1137"
integrity sha1-O9bW/ebjFyyTNMOzO2wZPYD+ETc=

http-signature@~1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/http-signature/-/http-signature-1.2.0.tgz#9aecd925114772f3d95b65a60abb8f7c18fbace1"
Expand Down Expand Up @@ -3724,6 +3712,11 @@ isobject@^3.0.0, isobject@^3.0.1:
resolved "https://registry.yarnpkg.com/isobject/-/isobject-3.0.1.tgz#4e431e92b11a9731636aa1f9c8d1ccbcfdab78df"
integrity sha1-TkMekrEalzFjaqH5yNHMvP2reN8=

isomorphic-ws@^4.0.1:
version "4.0.1"
resolved "https://registry.yarnpkg.com/isomorphic-ws/-/isomorphic-ws-4.0.1.tgz#55fd4cd6c5e6491e76dc125938dd863f5cd4f2dc"
integrity sha512-BhBvN2MBpWTaSHdWRb/bwdZJ1WaehQ2L1KngkCkfLUGF0mAWAT1sQUQacEmQ0jXkFw/czDXPNQSL5u2/Krsz1w==

isstream@~0.1.2:
version "0.1.2"
resolved "https://registry.yarnpkg.com/isstream/-/isstream-0.1.2.tgz#47e63f7af55afa6f92e1500e690eb8b8529c099a"
Expand Down Expand Up @@ -7311,19 +7304,6 @@ webidl-conversions@^4.0.2:
resolved "https://registry.yarnpkg.com/webidl-conversions/-/webidl-conversions-4.0.2.tgz#a855980b1f0b6b359ba1d5d9fb39ae941faa63ad"
integrity sha512-YQ+BmxuTgd6UXZW3+ICGfyqRyHXVlD5GtQr5+qjiNW7bF0cqrzX500HVXPBOvgXb5YnzDd+h0zqyv61KUD7+Sg==

websocket-driver@>=0.5.1:
version "0.7.0"
resolved "https://registry.yarnpkg.com/websocket-driver/-/websocket-driver-0.7.0.tgz#0caf9d2d755d93aee049d4bdd0d3fe2cca2a24eb"
integrity sha1-DK+dLXVdk67gSdS90NP+LMoqJOs=
dependencies:
http-parser-js ">=0.4.0"
websocket-extensions ">=0.1.1"

websocket-extensions@>=0.1.1:
version "0.1.3"
resolved "https://registry.yarnpkg.com/websocket-extensions/-/websocket-extensions-0.1.3.tgz#5d2ff22977003ec687a4b87073dfbbac146ccf29"
integrity sha512-nqHUnMXmBzT0w570r2JpJxfiSD1IzoI+HGVdd3aZ0yNi3ngvQ4jv1dtHt5VGxfI2yj5yqImPhOK4vmIh2xMbGg==

whatwg-encoding@^1.0.1, whatwg-encoding@^1.0.3:
version "1.0.5"
resolved "https://registry.yarnpkg.com/whatwg-encoding/-/whatwg-encoding-1.0.5.tgz#5abacf777c32166a51d085d6b4f3e7d27113ddb0"
Expand Down Expand Up @@ -7429,6 +7409,13 @@ ws@^5.1.1, ws@^5.2.0:
dependencies:
async-limiter "~1.0.0"

ws@^6.1.0:
version "6.1.0"
resolved "https://registry.yarnpkg.com/ws/-/ws-6.1.0.tgz#119a9dbf92c54e190ec18d10e871d55c95cf9373"
integrity sha512-H3dGVdGvW2H8bnYpIDc3u3LH8Wue3Qh+Zto6aXXFzvESkTVT6rAfKR6tR/+coaUvxs8yHtmNV0uioBF62ZGSTg==
dependencies:
async-limiter "~1.0.0"

xml-name-validator@^3.0.0:
version "3.0.0"
resolved "https://registry.yarnpkg.com/xml-name-validator/-/xml-name-validator-3.0.0.tgz#6ae73e06de4d8c6e47f9fb181f78d648ad457c6a"
Expand Down

0 comments on commit 703d18b

Please sign in to comment.