Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty field handling in MPD protocol handlers #1045

Closed
adamcik opened this issue Mar 17, 2015 · 4 comments

Comments

@adamcik
Copy link
Member

commented Mar 17, 2015

We should be leaving out blank fields based on my quick test against 0.18 as part of #923.

Mopidy:

$ netcat localhost 6600
OK MPD 0.17.0
add http://uwstream1.somafm.com:80
OK
play
OK
currentsong
file: http://uwstream1.somafm.com:80
Time: 0
Artist: 
Title: Groove Salad: a nicely chilled plate of ambient beats and grooves. [SomaFM]
Album: 
Track: 0
Pos: 0
Id: 0
Genre: Ambient Chill
OK

MPD:

$ netcat localhost 6601
OK MPD 0.18.0
add http://uwstream1.somafm.com:80
OK
play
OK
currentsong
file: http://uwstream1.somafm.com:80
Title: Bluetech - Dreamtime Lullaby
Name: Groove Salad: a nicely chilled plate of ambient beats and grooves. [SomaFM]
Pos: 0
Id: 17
OK

@adamcik adamcik added this to the v1.0.x milestone Apr 5, 2015

@adamcik adamcik modified the milestones: v1.1 - Gapless playback, v1.0.x Apr 12, 2015

@adamcik adamcik modified the milestones: v1.2 - Gapless, v1.1 - Robust core Apr 26, 2015

@adamcik adamcik modified the milestones: Europython 2015 sprint, v1.2 - Gapless Jun 24, 2015

@fatg3erman

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2015

I'm working on updating the MPD protocol to 0.19. I've changed concatenating multiple values to use a ';' instead of ', '. As I'm doing that, I could fix this as part of the same PR. Thoughts?

@adamcik

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2015

I would err towards smaller PRs when its not a lot more work to keep things apart. Makes reviewing easier :-)

@fatg3erman

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2015

OK :)

@adamcik

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2015

tagtypes
tagtype: Artist
tagtype: ArtistSort
tagtype: Album
tagtype: AlbumArtist
tagtype: AlbumArtistSort
tagtype: Title
tagtype: Track
tagtype: Name
tagtype: Genre
tagtype: Date
tagtype: Composer
tagtype: Performer
tagtype: Disc
tagtype: MUSICBRAINZ_ARTISTID
tagtype: MUSICBRAINZ_ALBUMID
tagtype: MUSICBRAINZ_ALBUMARTISTID
tagtype: MUSICBRAINZ_TRACKID

is the list of the metadata tags, I would start with filtering out these. Note that this is the same set of tags that is used in the tagnames command, so you might be able to use the list it uses.

@jodal jodal closed this in e0dc26f Jul 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.