New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break backend playback API to prepare for gapless playback #1052

Closed
jodal opened this Issue Mar 18, 2015 · 6 comments

Comments

3 participants
@jodal
Member

jodal commented Mar 18, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Mar 18, 2015

The following code will break when the equivalent of adamcik@9fc3190 happens, see top comment as things have been converted to TODOs and only the initial description TODOs show up on the overviews.

@jodal

This comment has been minimized.

Member

jodal commented Mar 18, 2015

@dz0ny @kingosticks @rattboi @hechtus Pinging you all since this will affect your extensions. The fix will be trivial, but a new release in coordination with Mopidy 1.0 will be needed.

@adamcik

This comment has been minimized.

Member

adamcik commented Mar 18, 2015

The tl;dr for migration is you should only be doing def change_track(self, track): ... which only needs to worry about setting the new URI. All the other things like preparing for change and the actual state change should not be handled by backends if we want to get gapless in 1.1 :-)

@jodal jodal added 3 - Done and removed 2 - Working labels Mar 21, 2015

@jodal jodal closed this Mar 22, 2015

@jodal jodal removed the 3 - Done label Mar 22, 2015

@jodal jodal reopened this Mar 23, 2015

@jodal

This comment has been minimized.

Member

jodal commented Mar 23, 2015

Breaking change landed in PR #1064.

The following extensions are up to date in their development branches:

  • mopidy-spotify (1 and 2)
  • mopidy-beets
  • mopidy-soundcloud

The following have pending PRs updating the API:

@jodal jodal added the 2 - Working label Mar 23, 2015

@jodal

This comment has been minimized.

Member

jodal commented Mar 23, 2015

Two more PRs to update backend playback API:

Closing this issue, as it should now be all in the hands of extension authors.

@jodal jodal closed this Mar 23, 2015

@jodal jodal removed the 2 - Working label Mar 23, 2015

@kingosticks

This comment has been minimized.

Member

kingosticks commented Mar 23, 2015

I'm done (mopidy-tunein)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment