Skip to content

/ mopidy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to stop using deprecated APIs #1083

Closed
adamcik opened this issue Mar 24, 2015 · 7 comments
Closed

Update tests to stop using deprecated APIs #1083

adamcik opened this issue Mar 24, 2015 · 7 comments
Assignees
@jodal
Labels
A-core C-enhancement good first issue
Projects
Mopidy 3 on Python 3
Milestone
v3.0.0

Comments

@adamcik
Copy link
Member

@adamcik adamcik commented Mar 24, 2015

TODO: add a list with things we should cleanup with respect to this after 1.0
@adamcik adamcik self-assigned this Mar 27, 2015
@adamcik

This comment has been minimized.

Sign in to view
Copy link
Member Author

@adamcik adamcik commented Mar 28, 2015

py.test -d --tx '4*popen//python=python2.7 -W error' --boxed has been the methodology so far. Splitting the test across jobs for speed. And using --boxed as warnings filters are global state that seems to keep leaking between tests.
@adamcik

This comment has been minimized.

Sign in to view
Copy link
Member Author

@adamcik adamcik commented Mar 29, 2015

A gotcha with this has turned out to get not getting the futures while inside the ignore warnings context.
@adamcik adamcik mentioned this issue Mar 29, 2015
Merged
@adamcik

This comment has been minimized.

Sign in to view
Copy link
Member Author

@adamcik adamcik commented Apr 5, 2015

The empty query case as not been handled by this yet. Rest should be done.
@adamcik adamcik removed their assignment Apr 8, 2015
@adamcik

This comment has been minimized.

Sign in to view
Copy link
Member Author

@adamcik adamcik commented Apr 26, 2015

Leaving this for now as we still have a lot of places we ignore deprecation. And we've not at all touched checking the deprecated properties usage.
@jodal jodal removed the C-bug label Sep 22, 2015
@jodal

This comment has been minimized.

Sign in to view
Copy link
Member

@jodal jodal commented Feb 22, 2016

Setting milestone to v3.0 as that is the latest we can fix this, since this blocks #1461.
@jodal jodal mentioned this issue Feb 22, 2016
Closed
35 of 36 tasks complete
@jodal jodal self-assigned this May 20, 2019
jodal added a commit to jodal/mopidy that referenced this issue Jun 4, 2019
@jodal
core: Remove all deprecated properties
ee873c4 
Greatly contributes towards mopidy#1083 and mopidy#1461.
@jodal jodal mentioned this issue Jun 4, 2019
Merged
jodal added a commit to jodal/mopidy that referenced this issue Jun 4, 2019
@jodal
core: Remove all deprecated properties
4965014 
Greatly contributes towards mopidy#1083 and mopidy#1461.
@jodal jodal mentioned this issue Nov 9, 2019
Closed
@jodal jodal removed their assignment Nov 9, 2019
@jodal

This comment has been minimized.

Sign in to view
Copy link
Member

@jodal jodal commented Nov 9, 2019

What remains to close this issue is just:

  • Update tests/core/test_playback.py to not use core.tracklist.add()'s tracks argument.
@jodal jodal added this to To do in Mopidy 3 on Python 3 via automation Dec 9, 2019
@jodal

This comment has been minimized.

Sign in to view
Copy link
Member

@jodal jodal commented Dec 14, 2019

I've deferred removing the tracks arg to core.tracklist.add() to Mopidy 4.0, ref. #1855.
@jodal jodal closed this Dec 14, 2019
Mopidy 3 on Python 3 automation moved this from To do to Done in master branch Dec 14, 2019
@jodal jodal self-assigned this Dec 14, 2019
@jodal jodal moved this from Done in master branch to Released in pre-release in Mopidy 3 on Python 3 Dec 14, 2019
@jodal jodal moved this from Released in pre-release to Released in final release in Mopidy 3 on Python 3 Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodal jodal

Labels
A-core C-enhancement good first issue
Projects
Mopidy 3 on Python 3
  
Released in final release
Milestone
  v3.0.0
2 participants
@adamcik @jodal
You can’t perform that action at this time.