New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist and browse result with same URI breaks MPD frontend #1120

Closed
trygveaa opened this Issue Apr 8, 2015 · 2 comments

Comments

3 participants
@trygveaa
Member

trygveaa commented Apr 8, 2015

If you have a playlist with a URI, and one of the results returned from library.browse has the same URI, listing of playlists in the MPD frontend may return a playlist with / in it, which breaks MPD clients.

In Spotify, I have the playlist spotify:user:spotify:playlist:4hOKQuZbraPDIfaGbM3lKI (Top 100 tracks currently on Spotify). When I list the playlists or browse "/" in the MPD frontend, that URI and name is inserted into the uri_map.

This playlist is also returned by the mopidy-spotify-tunigo extension under "/Spotify Browse/Top Lists/Top 100 tracks currently on Spotify". When browsing "/Spotify Browse/Top Lists", the URI is inserted into the uri_map with that path, overwriting the previous entry for the URI.

If I then list the playlists or browse / again, the URI won't be inserted into the uri_map again, since it already exists there. Instead the name will be looked up with the uri_map, however this will return the path from browsing "/Spotify Browse/..." instead of the playlist name.

@jodal jodal added this to the v1.0.x milestone Apr 8, 2015

@jodal

This comment has been minimized.

Member

jodal commented Apr 8, 2015

Thanks for a good bug report :-)

@jodal

This comment has been minimized.

Member

jodal commented Apr 23, 2015

Fixed by PR #1142

@jodal jodal closed this Apr 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment