New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support playlists with identical names #114

Closed
jodal opened this Issue Jun 15, 2011 · 5 comments

Comments

2 participants
@jodal
Member

jodal commented Jun 15, 2011

Spotify supports playlists with identical names. In our MPD frontend we should probably append "[1]", ”[2]”, etc. as the MPD protocol only references playlists by name, and they need to be unique.

@ghost ghost assigned jodal Aug 2, 2011

@jodal

This comment has been minimized.

Member

jodal commented Dec 29, 2011

It wouldn't solve this issue, but it would make the problem of multiple playlists with the same name smaller: We should append the Spotify playlist owner to the Mopidy playlist name, e.g. "Party mix by CoolGuy".

As requested by @torhve.

@jodal

This comment has been minimized.

Member

jodal commented Mar 25, 2013

@kingosticks I'm moving the discussion from #326 over to #114, as that's the topic now.

You're in luck as the Spotify backend currently doesn't have any tests.

If you fork, make a branch, make a fix you test a bit manually so that you're comfortable that it works properly, commit your fix to the branch, push the branch to GitHub and make a pull request of it, we'll review it and hopefully merge it.

@kingosticks

This comment has been minimized.

Member

kingosticks commented Mar 25, 2013

OK great, will do.

@jodal

This comment has been minimized.

Member

jodal commented Mar 30, 2013

As of 1c0601e the owner of Spotify playlists are included in the playlist name, somewhat reducing the impact of this issue, but not completely solving it.

@jodal

This comment has been minimized.

Member

jodal commented Apr 9, 2013

Fixed by #396 which was merged in 5af38b0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment