New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mopidy v1.0.1 no longer sends mute_changed events on core.mixer.set_mute() #1146

Closed
tkem opened this Issue Apr 25, 2015 · 3 comments

Comments

3 participants
@tkem
Member

tkem commented Apr 25, 2015

See
https://gist.github.com/tkem/4e1ce8178ca792cb427e
vs.
https://gist.github.com/tkem/734d7190874739d06f0b

This effectively breaks Mopidy-Mobile's "mute" button (though relying on the changed event for giving user feedback may be questionable in itself).

@adamcik

This comment has been minimized.

Member

adamcik commented Apr 25, 2015

Sounds like a regression we can and should fix. Since a lot of these things have the pattern make the change, wait for the event to show it actually happened.

@adamcik

This comment has been minimized.

Member

adamcik commented Apr 25, 2015

But not sure off the top of my head if say mopidy-alsamixer does this right.

@adamcik adamcik added this to the v1.0.2 milestone Apr 25, 2015

jodal added a commit that referenced this issue Apr 26, 2015

@jodal

This comment has been minimized.

Member

jodal commented Apr 26, 2015

Fixed in PR #1152.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment