New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy use in extensions #1156

Open
adamcik opened this Issue Apr 28, 2015 · 5 comments

Comments

4 participants
@adamcik
Member

adamcik commented Apr 28, 2015

At least the following extension should be setting correct proxy settings if they aren't already:

To make this easier we probably want a helper that constructs a proxy string from our config. The rest should likely just be solved by linking to urllib2 and requests docs on the subject. That is with respect to making sure other extensions also do this correctly.

@jodal jodal added the C-enhancement label Jun 25, 2015

@s256

This comment has been minimized.

s256 commented Jul 1, 2015

And the Stream extension. For Web-Radio. And mopidy-spotify-tunigo to access playlists.

@kingosticks

This comment has been minimized.

Member

kingosticks commented Jul 1, 2015

And the Stream extension

Isn't that already covered (0e4e872) ?

@adamcik

This comment has been minimized.

Member

adamcik commented Jul 1, 2015

The stream extension should be good once a version with that change is released. The other two I haven't checked.

Additionally we should probably make a note of the proxy handling "requirements" in the extension development docs.

jodal added a commit that referenced this issue Jul 5, 2015

@jodal

This comment has been minimized.

Member

jodal commented Jul 5, 2015

I added a section with HTTP request recommendations in commit 6673ae4 just now.

@jodal

This comment has been minimized.

Member

jodal commented Sep 22, 2015

I just released Mopidy-Spotify 2.1.0 which brought proxy support to both libspotify and HTTP usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment