Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config test helper #1226

Open
adamcik opened this issue Jul 20, 2015 · 3 comments
Open

Add a config test helper #1226

adamcik opened this issue Jul 20, 2015 · 3 comments
Assignees
Labels
C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal

Comments

@adamcik
Copy link
Member

adamcik commented Jul 20, 2015

As we add core config values that are needed for other "unrelated" tests to work we are getting a lot of places that set dummy configs. Ideally we should replace this with a tests.config({...}) which returns a merged config with the defaults we need.

@adamcik
Copy link
Member Author

adamcik commented Jul 20, 2015

#1225 adds a bunch of these which should be reverted once this gets fixed.

@RonaldZ
Copy link
Contributor

RonaldZ commented Jul 20, 2015

Was thinking the same thing while working on #1225. I'm on it.

@adamcik
Copy link
Member Author

adamcik commented Jul 20, 2015

Added you to the repo as a collaborator so you can take bugs etc :-)

@jodal jodal added the C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal label Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal
Projects
None yet
Development

No branches or pull requests

3 participants