New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making Extension.get_data_dir() etc. @classmethods #1275

Closed
tkem opened this Issue Sep 4, 2015 · 1 comment

Comments

3 participants
@tkem
Member

tkem commented Sep 4, 2015

Since LibraryProvider and other likely users of these methods don't have access to Extension instances, these are pretty much unusable without resorting to ugly hacks like creating a temporary Extension instance just to get access to the directory.

So I'd suggest either making these @classmethods, which should work in a backwards-compatible way, or giving backends somehow access to the Extension instance they're created from.

@jodal jodal added the C-enhancement label Sep 4, 2015

@jodal jodal added this to the v1.2 - Gapless milestone Sep 4, 2015

@jodal

This comment has been minimized.

Member

jodal commented Sep 4, 2015

We've discussed this a couple of times, and I don't find my own arguments for not making this a @classmethod compelling. Let's just do this :-)

@jodal jodal modified the milestones: v1.1.1 - Bugfixes, v1.2 - Gapless Sep 4, 2015

@jodal jodal assigned jodal and unassigned adamcik Sep 4, 2015

@jodal jodal closed this in f655fc7 Sep 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment