Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gapless: Fix seek race after about-to-finish #1305

Closed
adamcik opened this issue Oct 6, 2015 · 2 comments
Closed

gapless: Fix seek race after about-to-finish #1305

adamcik opened this issue Oct 6, 2015 · 2 comments
Assignees
Labels

Comments

@adamcik
Copy link
Member

@adamcik adamcik commented Oct 6, 2015

Currently you can seek in the wrong track. This needs to be fixed so we change tracks upon seeking when it happens before stream changed. To test this I highly recommend setting the output queue time to 5-15s min/max making it easy to reproduce.

@adamcik adamcik added this to the v1.2 - Gapless milestone Oct 6, 2015
@adamcik adamcik self-assigned this Nov 24, 2015
@adamcik
Copy link
Member Author

@adamcik adamcik commented Nov 24, 2015

Started adding a test and basic support for this. But currently running into the following issues:

  • We end up emitting a a lot of events that shouldn't really trigger
  • Just calling play() inside the seek() isn't really enough, we probably need to store a pending seek. And then trigger that at the right time.
@adamcik
Copy link
Member Author

@adamcik adamcik commented Dec 5, 2015

Fixed by #1346

@adamcik adamcik closed this Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant