New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch bad logging configs #1320

Closed
adamcik opened this Issue Oct 26, 2015 · 3 comments

Comments

2 participants
@adamcik
Member

adamcik commented Oct 26, 2015

We had a recent report where someone was struggling because their log config file had an error in it and it caused startup issues. We should probably wrap that code in and except that catches config parser errors just to improve our startup robustness and give a helpful error message.

@adamcik adamcik added the C-bug label Oct 26, 2015

@adamcik adamcik added this to the v1.1.2 - Bugfixes milestone Oct 26, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Dec 5, 2015

Fixed by ede5b8a

@adamcik adamcik closed this Dec 5, 2015

@jodal

This comment has been minimized.

Member

jodal commented Dec 5, 2015

Shouldn't this fix go into release-1.1?

@jodal jodal reopened this Dec 5, 2015

@jodal

This comment has been minimized.

Member

jodal commented Jan 1, 2016

Cherry-picked to release-1.1 in commit 92bb9b9.

@jodal jodal closed this Jan 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment